linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Renaud Cerrato <r.cerrato-6YL8BHNr0ZqHdZQakrT3ElaPQRlvutdw@public.gmane.org>
To: wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Renaud Cerrato
	<r.cerrato-6YL8BHNr0ZqHdZQakrT3ElaPQRlvutdw@public.gmane.org>
Subject: [PATCH] i2c-gpio: added support for I2C_M_STOP flag
Date: Thu, 20 Jun 2013 14:37:17 +0200	[thread overview]
Message-ID: <1371731837-1476-1-git-send-email-r.cerrato@til-technologies.fr> (raw)

Current i2c bit algo implementation doesn't actually support I2C_M_STOP flag despite I2C_FUNC_PROTOCOL_MANGLING functionnality.
---
 drivers/i2c/algos/i2c-algo-bit.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/i2c/algos/i2c-algo-bit.c b/drivers/i2c/algos/i2c-algo-bit.c
index fad22b0..00446a6 100644
--- a/drivers/i2c/algos/i2c-algo-bit.c
+++ b/drivers/i2c/algos/i2c-algo-bit.c
@@ -557,6 +557,12 @@ static int bit_xfer(struct i2c_adapter *i2c_adap,
 	for (i = 0; i < num; i++) {
 		pmsg = &msgs[i];
 		nak_ok = pmsg->flags & I2C_M_IGNORE_NAK;
+		if (pmsg->flags & I2C_M_STOP) {
+			if (i) {
+				bit_dbg(3, &i2c_adap->dev, "emitting stop condition\n");
+				i2c_stop(adap);
+			}
+		}
 		if (!(pmsg->flags & I2C_M_NOSTART)) {
 			if (i) {
 				bit_dbg(3, &i2c_adap->dev, "emitting "
-- 
1.7.2.5

             reply	other threads:[~2013-06-20 12:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-20 12:37 Renaud Cerrato [this message]
     [not found] ` <1371731837-1476-1-git-send-email-r.cerrato-6YL8BHNr0ZqHdZQakrT3ElaPQRlvutdw@public.gmane.org>
2013-06-20 19:39   ` [PATCH] i2c-gpio: added support for I2C_M_STOP flag Wolfram Sang
2013-06-24  6:37     ` Cerrato Renaud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1371731837-1476-1-git-send-email-r.cerrato@til-technologies.fr \
    --to=r.cerrato-6yl8bhnr0zqhdzqakrt3elapqrlvutdw@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).