From: Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Mika Westerberg
<mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
"Rafael J. Wysocki"
<rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] i2c: Not all adapters have a parent
Date: Thu, 10 Oct 2013 09:45:04 +0200 [thread overview]
Message-ID: <1381391104.4352.90.camel@chaos.site> (raw)
In-Reply-To: <20131010073529.GA2638@katana>
Hi Wolfram, Mika,
Le Thursday 10 October 2013 à 09:35 +0200, Wolfram Sang a écrit :
> On Thu, Oct 10, 2013 at 08:04:06AM +0200, Jean Delvare wrote:
> > The code in acpi_i2c_register_devices() assumes that all i2c adapters
> > have a parent. This is not necessarily the case, for example the
> > i2c-stub driver instantiate a virtual i2c adapter without a parent.
> > Check for this to avoid a NULL pointer deference.
> >
> > Signed-off-by: Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>
>
> Applied to for-current with stable tag, thanks!
I don't hit the bug on 3.11. Looking at the code, before it was moved in
3.12-rc1, acpi_i2c_register_devices() was only called explicitly from
i2c-designware. So the fix doesn't actually need to go to stable.
--
Jean Delvare
Suse L3 Support
prev parent reply other threads:[~2013-10-10 7:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 6:04 [PATCH] i2c: Not all adapters have a parent Jean Delvare
[not found] ` <20131010080406.3e0fd78e-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2013-10-10 6:15 ` Mika Westerberg
2013-10-10 7:35 ` Wolfram Sang
2013-10-10 7:45 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381391104.4352.90.camel@chaos.site \
--to=jdelvare-l3a5bk7wagm@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).