* [PATCH 2/2] i2c-piix4: Use different message for AMD Auxiliary SMBus Controller
@ 2014-01-22 22:06 Shane Huang
[not found] ` <1390428412-2269-1-git-send-email-shane.huang-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Shane Huang @ 2014-01-22 22:06 UTC (permalink / raw)
To: Jean Delvare; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Carl Peng, Shane Huang
Same messages for AMD main and auxiliary SMBus controllers lead to confusion,
this patch is to remove confusion and keep consistent with non-AMD products.
Signed-off-by: Shane Huang <shane.huang-5C7GfCeVMHo@public.gmane.org>
---
drivers/i2c/busses/i2c-piix4.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
index f71b4d3..d82b8ab 100644
--- a/drivers/i2c/busses/i2c-piix4.c
+++ b/drivers/i2c/busses/i2c-piix4.c
@@ -295,7 +295,8 @@ static int piix4_setup_sb800(struct pci_dev *PIIX4_dev,
/* Aux SMBus does not support IRQ information */
if (aux) {
dev_info(&PIIX4_dev->dev,
- "SMBus Host Controller at 0x%x\n", piix4_smba);
+ "Auxiliary SMBus Host Controller at 0x%x\n",
+ piix4_smba);
return piix4_smba;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1390428412-2269-1-git-send-email-shane.huang-5C7GfCeVMHo@public.gmane.org>]
* Re: [PATCH 2/2] i2c-piix4: Use different message for AMD Auxiliary SMBus Controller [not found] ` <1390428412-2269-1-git-send-email-shane.huang-5C7GfCeVMHo@public.gmane.org> @ 2014-01-23 12:43 ` Jean Delvare 2014-01-24 16:48 ` Wolfram Sang 1 sibling, 0 replies; 3+ messages in thread From: Jean Delvare @ 2014-01-23 12:43 UTC (permalink / raw) To: Shane Huang; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Carl Peng, Wolfram Sang On Wed, 22 Jan 2014 14:06:52 -0800, Shane Huang wrote: > Same messages for AMD main and auxiliary SMBus controllers lead to confusion, > this patch is to remove confusion and keep consistent with non-AMD products. > > Signed-off-by: Shane Huang <shane.huang-5C7GfCeVMHo@public.gmane.org> > --- > drivers/i2c/busses/i2c-piix4.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c > index f71b4d3..d82b8ab 100644 > --- a/drivers/i2c/busses/i2c-piix4.c > +++ b/drivers/i2c/busses/i2c-piix4.c > @@ -295,7 +295,8 @@ static int piix4_setup_sb800(struct pci_dev *PIIX4_dev, > /* Aux SMBus does not support IRQ information */ > if (aux) { > dev_info(&PIIX4_dev->dev, > - "SMBus Host Controller at 0x%x\n", piix4_smba); > + "Auxiliary SMBus Host Controller at 0x%x\n", > + piix4_smba); > return piix4_smba; > } > I like it very much, as it makes all these messages consistent across devices. And this allows string re-use for a small gain in size. Reviewed-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> Wolfram, please apply. -- Jean Delvare ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] i2c-piix4: Use different message for AMD Auxiliary SMBus Controller [not found] ` <1390428412-2269-1-git-send-email-shane.huang-5C7GfCeVMHo@public.gmane.org> 2014-01-23 12:43 ` Jean Delvare @ 2014-01-24 16:48 ` Wolfram Sang 1 sibling, 0 replies; 3+ messages in thread From: Wolfram Sang @ 2014-01-24 16:48 UTC (permalink / raw) To: Shane Huang; +Cc: Jean Delvare, linux-i2c-u79uwXL29TY76Z2rM5mHXA, Carl Peng [-- Attachment #1: Type: text/plain, Size: 337 bytes --] On Wed, Jan 22, 2014 at 02:06:52PM -0800, Shane Huang wrote: > Same messages for AMD main and auxiliary SMBus controllers lead to confusion, > this patch is to remove confusion and keep consistent with non-AMD products. > > Signed-off-by: Shane Huang <shane.huang-5C7GfCeVMHo@public.gmane.org> Applied to for-current, thanks! [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-24 16:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-22 22:06 [PATCH 2/2] i2c-piix4: Use different message for AMD Auxiliary SMBus Controller Shane Huang
[not found] ` <1390428412-2269-1-git-send-email-shane.huang-5C7GfCeVMHo@public.gmane.org>
2014-01-23 12:43 ` Jean Delvare
2014-01-24 16:48 ` Wolfram Sang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).