From: Curt Brune <curt-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
Laszlo Papp <lpapp-RoXCvvDuEio@public.gmane.org>
Cc: Thomas De Schampheleire
<patrickdepinguin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
Shrijeet Mukherjee
<shm-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
curt-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org
Subject: [PATCH v2 2/2] Add at24 based EEPROMs to the eeprom_dev hardware class
Date: Thu, 23 Jan 2014 11:16:02 -0800 [thread overview]
Message-ID: <1390504562-20333-2-git-send-email-curt@cumulusnetworks.com> (raw)
During device instantiation have the at24 driver add the new device to
the eeprom_dev hardware class. The functionality is enabled by
CONFIG_EEPROM_CLASS.
Signed-off-by: Curt Brune <curt-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>
---
drivers/misc/eeprom/at24.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index d87f77f..07782ea 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -22,10 +22,14 @@
#include <linux/jiffies.h>
#include <linux/of.h>
#include <linux/i2c.h>
#include <linux/platform_data/at24.h>
+#ifdef CONFIG_EEPROM_CLASS
+#include <linux/eeprom_class.h>
+#endif
+
/*
* I2C EEPROMs from most vendors are inexpensive and mostly interchangeable.
* Differences between different vendor product lines (like Atmel AT24C or
* MicroChip 24LC, etc) won't much matter for typical read/write access.
* There are also I2C RAM chips, likewise interchangeable. One example
@@ -66,10 +70,13 @@ struct at24_data {
u8 *writebuf;
unsigned write_max;
unsigned num_addresses;
+#ifdef CONFIG_EEPROM_CLASS
+ struct device *eeprom_dev;
+#endif
/*
* Some chips tie up multiple I2C addresses; dummy devices reserve
* them for us, and we'll use them with SMBus calls.
*/
struct i2c_client *client[];
@@ -619,10 +626,19 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id)
err = sysfs_create_bin_file(&client->dev.kobj, &at24->bin);
if (err)
goto err_clients;
+#ifdef CONFIG_EEPROM_CLASS
+ at24->eeprom_dev = eeprom_device_register(&client->dev);
+ if (IS_ERR(at24->eeprom_dev)) {
+ dev_err(&client->dev, "error registering eeprom device.\n");
+ err = PTR_ERR(at24->eeprom_dev);
+ goto err_clients;
+ }
+#endif
+
i2c_set_clientdata(client, at24);
dev_info(&client->dev, "%zu byte %s EEPROM, %s, %u bytes/write\n",
at24->bin.size, client->name,
writable ? "writable" : "read-only", at24->write_max);
@@ -656,10 +672,14 @@ static int at24_remove(struct i2c_client *client)
sysfs_remove_bin_file(&client->dev.kobj, &at24->bin);
for (i = 1; i < at24->num_addresses; i++)
i2c_unregister_device(at24->client[i]);
+#ifdef CONFIG_EEPROM_CLASS
+ eeprom_device_unregister(at24->eeprom_dev);
+#endif
+
return 0;
}
/*-------------------------------------------------------------------------*/
--
1.7.10.4
next reply other threads:[~2014-01-23 19:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 19:16 Curt Brune [this message]
[not found] ` <1390504562-20333-2-git-send-email-curt-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>
2014-01-26 12:45 ` [PATCH v2 2/2] Add at24 based EEPROMs to the eeprom_dev hardware class Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390504562-20333-2-git-send-email-curt@cumulusnetworks.com \
--to=curt-quqiamftcip+xzjcv9emoeeocmrvltnr@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lpapp-RoXCvvDuEio@public.gmane.org \
--cc=patrickdepinguin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=shm-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox