From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller Date: Thu, 20 Feb 2014 16:52:14 -0800 Message-ID: <1392943934.2594.14.camel@joe-AO722> References: <1392943090-30556-1-git-send-email-bjorn.andersson@sonymobile.com> <1392943090-30556-3-git-send-email-bjorn.andersson@sonymobile.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1392943090-30556-3-git-send-email-bjorn.andersson@sonymobile.com> Sender: linux-arm-msm-owner@vger.kernel.org To: Bjorn Andersson Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Rob Landley , Wolfram Sang , Grant Likely , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Andy Gross , Stephen Boyd , "Ivan T. Ivanov" List-Id: linux-i2c@vger.kernel.org On Thu, 2014-02-20 at 16:38 -0800, Bjorn Andersson wrote: > This bus driver supports the QUP i2c hardware controller in the Qualcomm SOCs. > The Qualcomm Universal Peripheral Engine (QUP) is a general purpose data path > engine with input/output FIFOs and an embedded i2c mini-core. The driver > supports FIFO mode (for low bandwidth applications) and block mode (interrupt > generated for each block-size data transfer). trivia: > diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c [] > +#ifdef CONFIG_PM_SLEEP > +static int qup_i2c_suspend(struct device *device) > +{ > + dev_dbg(device, "system suspend"); > + qup_i2c_pm_suspend_runtime(device); > + return 0; > +} > + > +static int qup_i2c_resume(struct device *device) > +{ > + dev_dbg(device, "system resume"); > + qup_i2c_pm_resume_runtime(device); > + pm_runtime_mark_last_busy(device); > + pm_request_autosuspend(device); > + return 0; > +} > +#endif Missing terminating newlines for dev_dbg statements.