From: Srinivas Pandruvada <srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org
Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ktsai-GubuWUlQtMwciDkP5Hr2oA@public.gmane.org,
Srinivas Pandruvada
<srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Subject: [RFC Patch v0 1/3] i2c-smbus: Add poll interface for smbus alert
Date: Wed, 26 Mar 2014 17:42:10 -0700 [thread overview]
Message-ID: <1395880932-19124-1-git-send-email-srinivas.pandruvada@linux.intel.com> (raw)
The current i2c smbus alert module depends on smbus alert mechanism
supported by underlying bus drivers. By specifications, these alerts
can be polled if there is no hardware support.
Currently multiple drivers who needs smbus alerts are creating
a new i2c dummy device with address 0x0C (ARA register), by luck
they don't co-exist. Otherwise i2c device creation will fail.
Added a poll interface, so that all these driver can call a common
interface to poll. Even if they polli, all drivers bound to an
adapater will be notified by their alert callback if ARA register
read is successful.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
drivers/i2c/i2c-smbus.c | 23 +++++++++++++++++++++++
include/linux/i2c-smbus.h | 3 +++
2 files changed, 26 insertions(+)
diff --git a/drivers/i2c/i2c-smbus.c b/drivers/i2c/i2c-smbus.c
index fc99f0d..e274f20 100644
--- a/drivers/i2c/i2c-smbus.c
+++ b/drivers/i2c/i2c-smbus.c
@@ -72,6 +72,29 @@ static int smbus_do_alert(struct device *dev, void *addrp)
return -EBUSY;
}
+int i2c_smbus_ara_poll(const struct i2c_client *client)
+{
+ union i2c_smbus_data data;
+ int status;
+ struct alert_data alert_data;
+
+ status = i2c_smbus_xfer(client->adapter, 0x0C, 0,
+ I2C_SMBUS_READ, 0,
+ I2C_SMBUS_BYTE, &data);
+ if (status < 0)
+ return status;
+
+ alert_data.flag = data.byte & 1;
+ alert_data.addr = data.byte >> 1;
+
+ /* Notify driver for the device which issued the alert */
+ device_for_each_child(&client->adapter->dev, &alert_data,
+ smbus_do_alert);
+
+ return data.byte;
+}
+EXPORT_SYMBOL_GPL(i2c_smbus_ara_poll);
+
/*
* The alert IRQ handler needs to hand work off to a task which can issue
* SMBus calls, because those sleeping calls can't be made in IRQ context.
diff --git a/include/linux/i2c-smbus.h b/include/linux/i2c-smbus.h
index 8f1b086..f70755d 100644
--- a/include/linux/i2c-smbus.h
+++ b/include/linux/i2c-smbus.h
@@ -48,4 +48,7 @@ struct i2c_client *i2c_setup_smbus_alert(struct i2c_adapter *adapter,
struct i2c_smbus_alert_setup *setup);
int i2c_handle_smbus_alert(struct i2c_client *ara);
+/* Interface to poll smbus alert */
+int i2c_smbus_ara_poll(const struct i2c_client *client);
+
#endif /* _LINUX_I2C_SMBUS_H */
--
1.8.3.2
next reply other threads:[~2014-03-27 0:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 0:42 Srinivas Pandruvada [this message]
[not found] ` <1395880932-19124-1-git-send-email-srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-03-27 0:42 ` [RFC Patch v0 2/3] i2c-smbus: Allow building with I2C_HELPER_AUTO support Srinivas Pandruvada
[not found] ` <1395880932-19124-2-git-send-email-srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-03-27 6:57 ` Jean Delvare
[not found] ` <20140327075712.5121d6ed-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2014-03-27 15:26 ` Srinivas Pandruvada
2014-03-27 0:42 ` [RFC Patch v0 3/3] iio: Capella cm3218x: smbus alert processing Srinivas Pandruvada
2014-03-27 7:44 ` [RFC Patch v0 1/3] i2c-smbus: Add poll interface for smbus alert Jean Delvare
[not found] ` <20140327084456.26527b4d-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2014-03-27 15:39 ` Srinivas Pandruvada
2014-03-27 17:34 ` Jonathan Cameron
[not found] ` <53349D41.4090209@linux.intel.com>
[not found] ` <53349D41.4090209-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-03-29 10:15 ` Jonathan Cameron
[not found] ` <53369D37.8010004-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-03-31 15:26 ` Srinivas Pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395880932-19124-1-git-send-email-srinivas.pandruvada@linux.intel.com \
--to=srinivas.pandruvada-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=ktsai-GubuWUlQtMwciDkP5Hr2oA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).