* [PATCH] i2c: nomadik: Don't use IS_ERR for devm_ioremap
@ 2014-04-10 14:19 Ulf Hansson
[not found] ` <1397139569-3906-1-git-send-email-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Ulf Hansson @ 2014-04-10 14:19 UTC (permalink / raw)
To: Wolfram Sang, linux-i2c-u79uwXL29TY76Z2rM5mHXA
Cc: Linus Walleij, Alessandro Rubini,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Ulf Hansson
devm_ioremap() returns NULL on error, not an error.
Cc: Alessandro Rubini <rubini-9wsNiZum9E8@public.gmane.org>
Cc: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Signed-off-by: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
drivers/i2c/busses/i2c-nomadik.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c
index 28cbe1b..32c85e9 100644
--- a/drivers/i2c/busses/i2c-nomadik.c
+++ b/drivers/i2c/busses/i2c-nomadik.c
@@ -999,7 +999,7 @@ static int nmk_i2c_probe(struct amba_device *adev, const struct amba_id *id)
dev->virtbase = devm_ioremap(&adev->dev, adev->res.start,
resource_size(&adev->res));
- if (IS_ERR(dev->virtbase)) {
+ if (!dev->virtbase) {
ret = -ENOMEM;
goto err_no_mem;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <1397139569-3906-1-git-send-email-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>]
* Re: [PATCH] i2c: nomadik: Don't use IS_ERR for devm_ioremap [not found] ` <1397139569-3906-1-git-send-email-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> @ 2014-05-06 9:32 ` Ulf Hansson [not found] ` <CAPDyKFo30t83UOvbPjH4DQ8JvvN-P290g_DdVq7hcu5cv+O0Zg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2014-05-14 15:57 ` Wolfram Sang 1 sibling, 1 reply; 4+ messages in thread From: Ulf Hansson @ 2014-05-06 9:32 UTC (permalink / raw) To: Wolfram Sang, Linus Walleij Cc: Alessandro Rubini, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Ulf Hansson On 10 April 2014 16:19, Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote: > devm_ioremap() returns NULL on error, not an error. > > Cc: Alessandro Rubini <rubini-9wsNiZum9E8@public.gmane.org> > Cc: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > Signed-off-by: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Linus, Wolfram - ping. Kind regards Ulf Hansson ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <CAPDyKFo30t83UOvbPjH4DQ8JvvN-P290g_DdVq7hcu5cv+O0Zg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] i2c: nomadik: Don't use IS_ERR for devm_ioremap [not found] ` <CAPDyKFo30t83UOvbPjH4DQ8JvvN-P290g_DdVq7hcu5cv+O0Zg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2014-05-06 18:48 ` Linus Walleij 0 siblings, 0 replies; 4+ messages in thread From: Linus Walleij @ 2014-05-06 18:48 UTC (permalink / raw) To: Ulf Hansson Cc: Wolfram Sang, Alessandro Rubini, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org On Tue, May 6, 2014 at 11:32 AM, Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote: > On 10 April 2014 16:19, Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote: >> devm_ioremap() returns NULL on error, not an error. >> >> Cc: Alessandro Rubini <rubini-9wsNiZum9E8@public.gmane.org> >> Cc: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> >> Signed-off-by: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > > Linus, Wolfram - ping. Acked-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Yours, Linus Walleij ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] i2c: nomadik: Don't use IS_ERR for devm_ioremap [not found] ` <1397139569-3906-1-git-send-email-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> 2014-05-06 9:32 ` Ulf Hansson @ 2014-05-14 15:57 ` Wolfram Sang 1 sibling, 0 replies; 4+ messages in thread From: Wolfram Sang @ 2014-05-14 15:57 UTC (permalink / raw) To: Ulf Hansson Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Linus Walleij, Alessandro Rubini, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r [-- Attachment #1: Type: text/plain, Size: 382 bytes --] On Thu, Apr 10, 2014 at 04:19:29PM +0200, Ulf Hansson wrote: > devm_ioremap() returns NULL on error, not an error. > > Cc: Alessandro Rubini <rubini-9wsNiZum9E8@public.gmane.org> > Cc: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> > Signed-off-by: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Applied to for-current, thanks! [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-14 15:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-10 14:19 [PATCH] i2c: nomadik: Don't use IS_ERR for devm_ioremap Ulf Hansson
[not found] ` <1397139569-3906-1-git-send-email-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-05-06 9:32 ` Ulf Hansson
[not found] ` <CAPDyKFo30t83UOvbPjH4DQ8JvvN-P290g_DdVq7hcu5cv+O0Zg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-06 18:48 ` Linus Walleij
2014-05-14 15:57 ` Wolfram Sang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).