From: Matthew Garrett <matthew.garrett@nebula.com>
To: "prarit@redhat.com" <prarit@redhat.com>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
"seth.heasley@intel.com" <seth.heasley@intel.com>,
"khali@linux-fr.org" <khali@linux-fr.org>,
"janet.morgan@intel.com" <janet.morgan@intel.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"mstowe@redhat.com" <mstowe@redhat.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH RFC] i2c algo, Add i2c-algo-i801 driver [v1]
Date: Thu, 10 Apr 2014 20:26:50 +0000 [thread overview]
Message-ID: <1397161609.5276.32.camel@x230> (raw)
In-Reply-To: <5346EDEA.3070704@redhat.com>
On Thu, 2014-04-10 at 15:15 -0400, Prarit Bhargava wrote:
>
> On 04/09/2014 01:09 PM, Matthew Garrett wrote:
> > Not really. These are an internal implementation detail, not an exported
> > interface. We try to write drivers for exported interfaces, even if
> > they're not documented.
>
> Aren't the methods the exported interface? I'm obviously missing something :)
No. The device doesn't have a _HID(), so they're internal methods.
> > Imagine an i2c chip with indexed register access. What stops:
> >
> > CPU0 (i2c): CPU1 (ACPI):
> > SBWB register address
> > SBWB register address
> > SBRB register value
> > SBRB register value
> >
> > and CPU0 getting back the wrong value?
>
> I thought that the "Serialized" keyword in the methods specifically indicate
> that this cannot happen.
It means you can't run the same method twice at the same time, but in
the above case you're not doing that. Nothing ensures that SBWB can't be
run again before SBRB is run.
--
Matthew Garrett <matthew.garrett@nebula.com>
next prev parent reply other threads:[~2014-04-10 20:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 16:22 [PATCH RFC] i2c algo, Add i2c-algo-i801 driver [v1] Prarit Bhargava
[not found] ` <1397060563-30431-1-git-send-email-prarit-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-09 16:36 ` Matthew Garrett
2014-04-09 17:02 ` Prarit Bhargava
[not found] ` <53457D0D.7020805-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-09 17:09 ` Matthew Garrett
2014-04-09 17:34 ` Prarit Bhargava
[not found] ` <5345849F.6070909-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-09 17:37 ` Matthew Garrett
2014-04-09 17:55 ` Prarit Bhargava
[not found] ` <53458992.4060003-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-09 17:59 ` Matthew Garrett
2014-04-09 18:02 ` Prarit Bhargava
[not found] ` <53458B2A.30003-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-09 18:27 ` Matthew Garrett
2014-04-09 19:22 ` Jean Delvare
2014-04-09 19:24 ` Matthew Garrett
2014-04-09 19:01 ` Jean Delvare
2014-04-09 19:05 ` Matthew Garrett
2014-04-10 19:15 ` Prarit Bhargava
2014-04-10 20:26 ` Matthew Garrett [this message]
2014-04-11 17:47 ` Prarit Bhargava
[not found] ` <53482AC2.2060605-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-11 18:55 ` Matthew Garrett
2014-04-09 18:56 ` Jean Delvare
2014-04-09 18:58 ` Matthew Garrett
2014-04-09 20:25 ` Jean Delvare
2014-04-09 16:37 ` Jean Delvare
2014-04-09 16:57 ` Prarit Bhargava
[not found] ` <53457C00.1030400-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-04-09 20:27 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397161609.5276.32.camel@x230 \
--to=matthew.garrett@nebula.com \
--cc=bhelgaas@google.com \
--cc=janet.morgan@intel.com \
--cc=khali@linux-fr.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=mstowe@redhat.com \
--cc=prarit@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=seth.heasley@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).