From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ivan T. Ivanov" Subject: Re: [PATCH] i2c: qup: Fix pm_runtime_get_sync usage Date: Sat, 03 May 2014 09:40:52 +0300 Message-ID: <1399099252.4310.1.camel@violet> References: <1399082069-6666-1-git-send-email-agross@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1399082069-6666-1-git-send-email-agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andy Gross Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Bjorn Andersson , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Fri, 2014-05-02 at 20:54 -0500, Andy Gross wrote: > This patch corrects the error check on the call to pm_runtime_get_sync. > > Signed-off-by: Andy Gross Reviewed-by: Ivan T. Ivanov > --- > drivers/i2c/busses/i2c-qup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c > index 1b4cf14..2a5efb5 100644 > --- a/drivers/i2c/busses/i2c-qup.c > +++ b/drivers/i2c/busses/i2c-qup.c > @@ -479,7 +479,7 @@ static int qup_i2c_xfer(struct i2c_adapter *adap, > int ret, idx; > > ret = pm_runtime_get_sync(qup->dev); > - if (ret) > + if (ret < 0) > goto out; > > writel(1, qup->base + QUP_SW_RESET);