From: Wolfram Sang <wsa@the-dreams.de>
To: linux-i2c@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
Wolfram Sang <wsa@the-dreams.de>, Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 12/16] i2c: i2c-s3c2410: Drop class based scanning to improve bootup time
Date: Thu, 10 Jul 2014 13:46:32 +0200 [thread overview]
Message-ID: <1404992799-3705-13-git-send-email-wsa@the-dreams.de> (raw)
In-Reply-To: <1404992799-3705-1-git-send-email-wsa@the-dreams.de>
This driver has been flagged to drop class based instantiation. The removal
improves boot-up time and is unneeded for embedded controllers. Users have been
warned to switch for some time now, so we can actually do the removal. Keep the
DEPRECATED flag, so the core can inform users that the behaviour finally
changed now. After another transition period, this flag can go, too.
While we are here, remove the indentation for the array setup because
such things always break after some time.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/i2c/busses/i2c-s3c2410.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index e828a1dba0e5..6252c051525a 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -1128,11 +1128,11 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
s3c24xx_i2c_parse_dt(pdev->dev.of_node, i2c);
strlcpy(i2c->adap.name, "s3c2410-i2c", sizeof(i2c->adap.name));
- i2c->adap.owner = THIS_MODULE;
- i2c->adap.algo = &s3c24xx_i2c_algorithm;
+ i2c->adap.owner = THIS_MODULE;
+ i2c->adap.algo = &s3c24xx_i2c_algorithm;
i2c->adap.retries = 2;
- i2c->adap.class = I2C_CLASS_HWMON | I2C_CLASS_SPD | I2C_CLASS_DEPRECATED;
- i2c->tx_setup = 50;
+ i2c->adap.class = I2C_CLASS_DEPRECATED;
+ i2c->tx_setup = 50;
init_waitqueue_head(&i2c->wait);
--
2.0.0
next prev parent reply other threads:[~2014-07-10 11:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 11:46 [PATCH 00/16] i2c: drop class based instantiaion for selected drivers Wolfram Sang
2014-07-10 11:46 ` [PATCH 01/16] i2c: add debug info when class instantiation was dropped Wolfram Sang
2014-07-10 11:46 ` [PATCH 02/16] i2c: i2c-at91: Drop class based scanning to improve bootup time Wolfram Sang
2014-07-17 15:27 ` Ludovic Desroches
2014-07-10 11:46 ` [PATCH 03/16] i2c: i2c-bcm2835: " Wolfram Sang
2014-07-10 11:46 ` [PATCH 04/16] i2c: i2c-bfin-twi: " Wolfram Sang
2014-07-10 11:46 ` [PATCH 06/16] i2c: i2c-designware-platdrv: " Wolfram Sang
2014-07-10 11:46 ` [PATCH 07/16] i2c: i2c-mv64xxx: " Wolfram Sang
2014-07-21 13:33 ` Andrew Lunn
2014-07-10 11:46 ` [PATCH 08/16] i2c: i2c-nomadik: " Wolfram Sang
[not found] ` <1404992799-3705-9-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-07-10 14:35 ` Linus Walleij
2014-07-10 11:46 ` [PATCH 09/16] i2c: i2c-ocores: " Wolfram Sang
[not found] ` <1404992799-3705-10-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-07-10 14:32 ` Peter Korsgaard
2014-07-10 11:46 ` [PATCH 10/16] i2c: i2c-omap: " Wolfram Sang
2014-07-10 11:46 ` [PATCH 11/16] i2c: i2c-rcar: " Wolfram Sang
2014-07-10 11:46 ` Wolfram Sang [this message]
2014-07-11 5:59 ` [PATCH 12/16] i2c: i2c-s3c2410: " Sachin Kamat
2014-07-10 11:46 ` [PATCH 13/16] i2c: i2c-sirf: " Wolfram Sang
2014-07-10 11:46 ` [PATCH 14/16] i2c: i2c-stu300: " Wolfram Sang
2014-07-10 14:35 ` Linus Walleij
2014-07-10 11:46 ` [PATCH 15/16] i2c: i2c-tegra: " Wolfram Sang
[not found] ` <1404992799-3705-16-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-07-10 12:34 ` Mikko Perttunen
2014-07-10 13:43 ` Thierry Reding
2014-07-10 11:46 ` [PATCH 16/16] i2c: i2c-xiic: " Wolfram Sang
[not found] ` <1404992799-3705-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-07-10 11:46 ` [PATCH 05/16] i2c: i2c-davinci: " Wolfram Sang
2014-07-10 12:38 ` [PATCH 00/16] i2c: drop class based instantiaion for selected drivers Lothar Waßmann
[not found] ` <20140710143837.558c1d07-VjFSrY7JcPWvSplVBqRQBQ@public.gmane.org>
2014-07-10 13:13 ` Wolfram Sang
2014-07-16 17:46 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404992799-3705-13-git-send-email-wsa@the-dreams.de \
--to=wsa@the-dreams.de \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).