From: Wolfram Sang <wsa@the-dreams.de>
To: linux-i2c@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Wolfram Sang <wsa@the-dreams.de>
Subject: [PATCH 01/16] i2c: add debug info when class instantiation was dropped
Date: Thu, 10 Jul 2014 13:46:21 +0200 [thread overview]
Message-ID: <1404992799-3705-2-git-send-email-wsa@the-dreams.de> (raw)
In-Reply-To: <1404992799-3705-1-git-send-email-wsa@the-dreams.de>
We have a warning already when support for old-fashioned class based
instantiation is about to be dropped somewhen soon from a driver. Let's
have another one when it was actually dropped. This allows to remove the
cruft a little earlier and still let users know what happened in the
rare case they are missing devices after the change. However, there is
enough interest to get rid of class based instantiation rather sooner
than later because it improves boot up time.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/i2c/i2c-core.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 4ccff114b147..a1eeb8a5d3f8 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -1915,6 +1915,16 @@ static int i2c_detect(struct i2c_adapter *adapter, struct i2c_driver *driver)
if (!driver->detect || !address_list)
return 0;
+ /* Warn that the adapter lost class based instantiation */
+ if (adapter->class == I2C_CLASS_DEPRECATED) {
+ dev_dbg(&adapter->dev,
+ "This adapter dropped support for I2C classes and "
+ "won't auto-detect %s devices anymore. If you need it, check "
+ "'Documentation/i2c/instantiating-devices' for alternatives.\n",
+ driver->driver.name);
+ return 0;
+ }
+
/* Stop here if the classes do not match */
if (!(adapter->class & driver->class))
return 0;
--
2.0.0
next prev parent reply other threads:[~2014-07-10 11:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 11:46 [PATCH 00/16] i2c: drop class based instantiaion for selected drivers Wolfram Sang
2014-07-10 11:46 ` Wolfram Sang [this message]
2014-07-10 11:46 ` [PATCH 02/16] i2c: i2c-at91: Drop class based scanning to improve bootup time Wolfram Sang
2014-07-17 15:27 ` Ludovic Desroches
2014-07-10 11:46 ` [PATCH 03/16] i2c: i2c-bcm2835: " Wolfram Sang
2014-07-10 11:46 ` [PATCH 04/16] i2c: i2c-bfin-twi: " Wolfram Sang
2014-07-10 11:46 ` [PATCH 06/16] i2c: i2c-designware-platdrv: " Wolfram Sang
2014-07-10 11:46 ` [PATCH 07/16] i2c: i2c-mv64xxx: " Wolfram Sang
2014-07-21 13:33 ` Andrew Lunn
2014-07-10 11:46 ` [PATCH 08/16] i2c: i2c-nomadik: " Wolfram Sang
[not found] ` <1404992799-3705-9-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-07-10 14:35 ` Linus Walleij
2014-07-10 11:46 ` [PATCH 09/16] i2c: i2c-ocores: " Wolfram Sang
[not found] ` <1404992799-3705-10-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-07-10 14:32 ` Peter Korsgaard
2014-07-10 11:46 ` [PATCH 10/16] i2c: i2c-omap: " Wolfram Sang
2014-07-10 11:46 ` [PATCH 11/16] i2c: i2c-rcar: " Wolfram Sang
2014-07-10 11:46 ` [PATCH 12/16] i2c: i2c-s3c2410: " Wolfram Sang
2014-07-11 5:59 ` Sachin Kamat
2014-07-10 11:46 ` [PATCH 13/16] i2c: i2c-sirf: " Wolfram Sang
2014-07-10 11:46 ` [PATCH 14/16] i2c: i2c-stu300: " Wolfram Sang
2014-07-10 14:35 ` Linus Walleij
2014-07-10 11:46 ` [PATCH 15/16] i2c: i2c-tegra: " Wolfram Sang
[not found] ` <1404992799-3705-16-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-07-10 12:34 ` Mikko Perttunen
2014-07-10 13:43 ` Thierry Reding
2014-07-10 11:46 ` [PATCH 16/16] i2c: i2c-xiic: " Wolfram Sang
[not found] ` <1404992799-3705-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2014-07-10 11:46 ` [PATCH 05/16] i2c: i2c-davinci: " Wolfram Sang
2014-07-10 12:38 ` [PATCH 00/16] i2c: drop class based instantiaion for selected drivers Lothar Waßmann
[not found] ` <20140710143837.558c1d07-VjFSrY7JcPWvSplVBqRQBQ@public.gmane.org>
2014-07-10 13:13 ` Wolfram Sang
2014-07-16 17:46 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404992799-3705-2-git-send-email-wsa@the-dreams.de \
--to=wsa@the-dreams.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).