linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Lee Jones <lee.jones@linaro.org>
Cc: Wolfram Sang <wsa@the-dreams.de>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Doug Anderson <dianders@chromium.org>,
	Simon Glass <sjg@chromium.org>,
	Bill Richardson <wfrichar@chromium.org>,
	Andrew Bresticker <abrestic@chromium.org>,
	Derek Basehore <dbasehore@chromium.org>,
	Gwendal Grignou <gwendal@google.com>,
	linux-i2c@vger.kernel.org, linux-input@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org,
	Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Subject: [PATCH v4 2/5] i2c: i2c-cros-ec-tunnel: Set retries to 3
Date: Thu, 18 Sep 2014 17:18:55 +0200	[thread overview]
Message-ID: <1411053538-17237-3-git-send-email-javier.martinez@collabora.co.uk> (raw)
In-Reply-To: <1411053538-17237-1-git-send-email-javier.martinez@collabora.co.uk>

From: Derek Basehore <dbasehore@chromium.org>

Since the i2c bus can get wedged on the EC sometimes, set the number of retries
to 3. Since we un-wedge the bus immediately after the wedge happens, this is the
correct fix since only one transfer will fail.

Signed-off-by: Derek Basehore <dbasehore@chromium.org>
Reviewed-by: Doug Anderson <dianders@chromium.org>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
 drivers/i2c/busses/i2c-cros-ec-tunnel.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/i2c/busses/i2c-cros-ec-tunnel.c b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
index 3c15dcc..97e6369 100644
--- a/drivers/i2c/busses/i2c-cros-ec-tunnel.c
+++ b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
@@ -16,6 +16,8 @@
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 
+#define I2C_MAX_RETRIES 3
+
 /**
  * struct ec_i2c_device - Driver data for I2C tunnel
  *
@@ -290,6 +292,7 @@ static int ec_i2c_probe(struct platform_device *pdev)
 	bus->adap.algo_data = bus;
 	bus->adap.dev.parent = &pdev->dev;
 	bus->adap.dev.of_node = np;
+	bus->adap.retries = I2C_MAX_RETRIES;
 
 	err = i2c_add_adapter(&bus->adap);
 	if (err) {
-- 
2.1.0

  parent reply	other threads:[~2014-09-18 15:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-18 15:18 [PATCH v4 0/5] Second batch of cleanups for cros_ec Javier Martinez Canillas
     [not found] ` <1411053538-17237-1-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2014-09-18 15:18   ` [PATCH v4 1/5] mfd: cros_ec: Delay for 50ms when we see EC_CMD_REBOOT_EC Javier Martinez Canillas
2014-09-29  7:49     ` Lee Jones
2014-09-18 15:18   ` [PATCH v4 5/5] mfd: cros_ec: wait for completion of commands that return IN_PROGRESS Javier Martinez Canillas
2014-09-29  7:52     ` Lee Jones
2014-09-18 15:18 ` Javier Martinez Canillas [this message]
2014-09-29  7:49   ` [PATCH v4 2/5] i2c: i2c-cros-ec-tunnel: Set retries to 3 Lee Jones
2014-09-29  7:50     ` Lee Jones
2014-09-29  9:19       ` Wolfram Sang
2014-09-18 15:18 ` [PATCH v4 3/5] mfd: cros_ec: stop calling ->cmd_xfer() directly Javier Martinez Canillas
     [not found]   ` <1411053538-17237-4-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2014-09-29  7:50     ` Lee Jones
2014-09-18 15:18 ` [PATCH v4 4/5] mfd: cros_ec: move locking into cros_ec_cmd_xfer Javier Martinez Canillas
     [not found]   ` <1411053538-17237-5-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2014-09-29  7:51     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411053538-17237-3-git-send-email-javier.martinez@collabora.co.uk \
    --to=javier.martinez@collabora.co.uk \
    --cc=abrestic@chromium.org \
    --cc=dbasehore@chromium.org \
    --cc=dianders@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gwendal@google.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=sjg@chromium.org \
    --cc=wfrichar@chromium.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).