From: Wolfram Sang <wsa@the-dreams.de>
To: linux-i2c@vger.kernel.org
Cc: linux-sh@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH 3/5] i2c: sh_mobile: improve success message
Date: Fri, 7 Nov 2014 11:11:42 +0100 [thread overview]
Message-ID: <1415355104-2031-4-git-send-email-wsa@the-dreams.de> (raw)
In-Reply-To: <1415355104-2031-1-git-send-email-wsa@the-dreams.de>
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
No user needs magic hex values, makes this debug output. Add DMA info.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/i2c/busses/i2c-sh_mobile.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c
index 1e0aa597dd04..903bb22aa5b4 100644
--- a/drivers/i2c/busses/i2c-sh_mobile.c
+++ b/drivers/i2c/busses/i2c-sh_mobile.c
@@ -293,6 +293,7 @@ static int sh_mobile_i2c_init(struct sh_mobile_i2c_data *pd)
else
pd->icic &= ~ICIC_ICCHB8;
+ dev_dbg(pd->dev, "timing values: L/H=0x%x/0x%x\n", pd->iccl, pd->icch);
return 0;
}
@@ -937,9 +938,8 @@ static int sh_mobile_i2c_probe(struct platform_device *dev)
return ret;
}
- dev_info(&dev->dev,
- "I2C adapter %d with bus speed %lu Hz (L/H=0x%x/0x%x)\n",
- adap->nr, pd->bus_speed, pd->iccl, pd->icch);
+ dev_info(&dev->dev, "I2C adapter %d, bus speed %lu Hz, DMA=%c\n",
+ adap->nr, pd->bus_speed, (pd->dma_rx || pd->dma_tx) ? 'y' : 'n');
return 0;
}
--
2.1.1
next prev parent reply other threads:[~2014-11-07 10:11 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 10:11 [PATCH 0/5] i2c: sh_mobile: add DMA support Wolfram Sang
2014-11-07 10:11 ` [PATCH 1/5] i2c: sh_mobile: sort includes alphabetically Wolfram Sang
2014-11-12 16:10 ` Wolfram Sang
2014-11-07 10:11 ` [PATCH 2/5] i2c: sh_mobile: add DMA support Wolfram Sang
2014-11-12 16:11 ` Wolfram Sang
2014-12-09 10:53 ` Geert Uytterhoeven
2014-12-09 14:09 ` Wolfram Sang
2014-12-10 5:44 ` Magnus Damm
2014-12-10 8:01 ` Wolfram Sang
2014-12-10 14:19 ` Laurent Pinchart
2014-12-10 14:23 ` Wolfram Sang
2014-12-11 5:02 ` Vinod Koul
2014-12-11 7:37 ` Wolfram Sang
2014-12-11 7:47 ` Laurent Pinchart
2014-12-11 8:28 ` Wolfram Sang
2014-12-11 21:42 ` Laurent Pinchart
2014-12-11 21:47 ` Wolfram Sang
2014-12-11 21:52 ` Laurent Pinchart
2014-12-12 11:07 ` Wolfram Sang
2014-12-15 6:43 ` Vinod Koul
2014-12-15 8:31 ` Geert Uytterhoeven
2014-12-15 9:06 ` Wolfram Sang
2014-12-15 9:32 ` Geert Uytterhoeven
2014-12-15 9:13 ` Vinod Koul
[not found] ` <20141215091314.GQ16827-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-15 9:42 ` Laurent Pinchart
2014-12-15 14:48 ` Vinod Koul
2014-12-15 9:45 ` Wolfram Sang
2014-12-15 14:50 ` Vinod Koul
2014-11-07 10:11 ` Wolfram Sang [this message]
2014-11-12 16:12 ` [PATCH 3/5] i2c: sh_mobile: improve success message Wolfram Sang
2014-11-13 0:27 ` Simon Horman
2014-11-07 10:11 ` [PATCH 4/5] ARM: shmobile: r8a7790: add DMA nodes for IIC Wolfram Sang
2014-11-13 0:26 ` Simon Horman
2014-11-07 10:11 ` [PATCH 5/5] ARM: shmobile: r8a7791: " Wolfram Sang
2014-11-13 0:26 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415355104-2031-4-git-send-email-wsa@the-dreams.de \
--to=wsa@the-dreams.de \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).