linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Octavian Purdila <octavian.purdila@intel.com>
To: lee.jones@linaro.org
Cc: wsa@the-dreams.de, julia.lawall@lip6.fr,
	dan.carpenter@oracle.com, johan@kernel.org,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	Octavian Purdila <octavian.purdila@intel.com>
Subject: [PATCH v2 3/4] mfd: dln2: add a limit check for invalid echo
Date: Tue, 18 Nov 2014 14:57:59 +0200	[thread overview]
Message-ID: <1416315480-2053-4-git-send-email-octavian.purdila@intel.com> (raw)
In-Reply-To: <1416315480-2053-1-git-send-email-octavian.purdila@intel.com>

The echo field in dln2_transfer_complete comes directly from an USB
transfer and we should not trust it is valid.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
---
 drivers/mfd/dln2.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c
index cf22841..df2fda9 100644
--- a/drivers/mfd/dln2.c
+++ b/drivers/mfd/dln2.c
@@ -195,6 +195,9 @@ static bool dln2_transfer_complete(struct dln2_dev *dln2, struct urb *urb,
 	struct dln2_rx_context *rxc;
 	bool valid_slot = false;
 
+	if (rx_slot >= DLN2_MAX_RX_SLOTS)
+		goto out;
+
 	rxc = &rxs->slots[rx_slot];
 
 	/*
@@ -210,6 +213,7 @@ static bool dln2_transfer_complete(struct dln2_dev *dln2, struct urb *urb,
 	}
 	spin_unlock(&rxs->lock);
 
+out:
 	if (!valid_slot)
 		dev_warn(dev, "bad/late response %d/%d\n", handle, rx_slot);
 
-- 
1.9.1

  parent reply	other threads:[~2014-11-18 12:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-18 12:57 [PATCH v2 0/4] dln2 fixes for ib-mfd-gpio-i2c-3.19 Octavian Purdila
2014-11-18 12:57 ` [PATCH v2 1/4] mfd: dln2: fix _dln2_transfer return code Octavian Purdila
2014-11-18 12:57 ` [PATCH v2 2/4] i2c: dln2: simplify return flow for dln2_i2c_enable Octavian Purdila
2014-11-18 12:57 ` Octavian Purdila [this message]
2014-11-18 12:58 ` [PATCH v2 4/4] mfd: dln2: a couple endian fixes Octavian Purdila
     [not found] ` <1416315480-2053-1-git-send-email-octavian.purdila-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-19 17:34   ` [GIT PULL] Immutable branch between MFD, GPIO and I2C (Second batch) Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416315480-2053-4-git-send-email-octavian.purdila@intel.com \
    --to=octavian.purdila@intel.com \
    --cc=dan.carpenter@oracle.com \
    --cc=johan@kernel.org \
    --cc=julia.lawall@lip6.fr \
    --cc=lee.jones@linaro.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).