From mboxrd@z Thu Jan 1 00:00:00 1970 From: Octavian Purdila Subject: [PATCH v2 3/4] mfd: dln2: add a limit check for invalid echo Date: Tue, 18 Nov 2014 14:57:59 +0200 Message-ID: <1416315480-2053-4-git-send-email-octavian.purdila@intel.com> References: <1416315480-2053-1-git-send-email-octavian.purdila@intel.com> Return-path: In-Reply-To: <1416315480-2053-1-git-send-email-octavian.purdila@intel.com> Sender: linux-kernel-owner@vger.kernel.org To: lee.jones@linaro.org Cc: wsa@the-dreams.de, julia.lawall@lip6.fr, dan.carpenter@oracle.com, johan@kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Octavian Purdila List-Id: linux-i2c@vger.kernel.org The echo field in dln2_transfer_complete comes directly from an USB transfer and we should not trust it is valid. Reported-by: Dan Carpenter Signed-off-by: Octavian Purdila --- drivers/mfd/dln2.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c index cf22841..df2fda9 100644 --- a/drivers/mfd/dln2.c +++ b/drivers/mfd/dln2.c @@ -195,6 +195,9 @@ static bool dln2_transfer_complete(struct dln2_dev *dln2, struct urb *urb, struct dln2_rx_context *rxc; bool valid_slot = false; + if (rx_slot >= DLN2_MAX_RX_SLOTS) + goto out; + rxc = &rxs->slots[rx_slot]; /* @@ -210,6 +213,7 @@ static bool dln2_transfer_complete(struct dln2_dev *dln2, struct urb *urb, } spin_unlock(&rxs->lock); +out: if (!valid_slot) dev_warn(dev, "bad/late response %d/%d\n", handle, rx_slot); -- 1.9.1