* [PATCH] i2c: sh_mobile: fix uninitialized var when debug is enabled
@ 2014-12-20 8:36 Wolfram Sang
2014-12-20 18:51 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2014-12-20 8:36 UTC (permalink / raw)
To: linux-i2c
Cc: linux-sh, Wolfram Sang, Magnus Damm, Simon Horman,
Laurent Pinchart, Geert Uytterhoeven
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/i2c/busses/i2c-sh_mobile.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c
index a12297e7680a..440d5dbc8b5f 100644
--- a/drivers/i2c/busses/i2c-sh_mobile.c
+++ b/drivers/i2c/busses/i2c-sh_mobile.c
@@ -550,6 +550,7 @@ static struct dma_chan *sh_mobile_i2c_request_dma_chan(struct device *dev,
chan = dma_request_slave_channel_reason(dev, chan_name);
if (IS_ERR(chan)) {
+ ret = PTR_ERR(chan);
dev_dbg(dev, "request_channel failed for %s (%d)\n", chan_name, ret);
return chan;
}
--
2.1.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] i2c: sh_mobile: fix uninitialized var when debug is enabled
2014-12-20 8:36 [PATCH] i2c: sh_mobile: fix uninitialized var when debug is enabled Wolfram Sang
@ 2014-12-20 18:51 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2014-12-20 18:51 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, linux-sh, Magnus Damm, Simon Horman,
Geert Uytterhoeven
Hi Wolfram,
Thank you for tha patch.
On Saturday 20 December 2014 09:36:42 Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
> drivers/i2c/busses/i2c-sh_mobile.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-sh_mobile.c
> b/drivers/i2c/busses/i2c-sh_mobile.c index a12297e7680a..440d5dbc8b5f
> 100644
> --- a/drivers/i2c/busses/i2c-sh_mobile.c
> +++ b/drivers/i2c/busses/i2c-sh_mobile.c
> @@ -550,6 +550,7 @@ static struct dma_chan
> *sh_mobile_i2c_request_dma_chan(struct device *dev,
>
> chan = dma_request_slave_channel_reason(dev, chan_name);
> if (IS_ERR(chan)) {
> + ret = PTR_ERR(chan);
> dev_dbg(dev, "request_channel failed for %s (%d)\n", chan_name, ret);
You could just do
dev_dbg(dev, "request_channel failed for %s (%d)\n", chan_name,
PTR_ERR(chan));
but that's up to you.
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> return chan;
> }
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-20 18:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-20 8:36 [PATCH] i2c: sh_mobile: fix uninitialized var when debug is enabled Wolfram Sang
2014-12-20 18:51 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).