Re: [PATCH 3/3] i2c: imx: whitespace and checkpatch cleanup

[Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

Hi Andy,

Am Mittwoch, den 07.01.2015, 02:36 +0000 schrieb
fugang.duan-KZfg59tc24xl57MIdRCFDg@public.gmane.org:
> From: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Sent: Tuesday, January 06, 2015 10:48 PM
> > To: Wolfram Sang
> > Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Duan Fugang-B38611; Yuan Yao-B46683;
> > Estevam Fabio-R49496; kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org; Philipp Zabel
> > Subject: [PATCH 3/3] i2c: imx: whitespace and checkpatch cleanup
> > 
> > This patch fixes up some whitespace issues and addresses a few checkpatch
> > warnings.
> > 
> > Signed-off-by: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > ---
> >  drivers/i2c/busses/i2c-imx.c | 53 ++++++++++++++++++++++++++------------
> > ------
> >  1 file changed, 32 insertions(+), 21 deletions(-)
> 
> [snip]
> >  		if (i == (msgs->len - 1)) {
> >  			if (is_lastmsg) {
> >  				/*
> > -				 * It must generate STOP before read I2DR to
> > prevent
> > -				 * controller from generating another clock cycle
> > +				 * It must generate STOP before read I2DR to
> > +				 * prevent controller from generating another
> > +				 * clock cycle
> >  				 */
> 
> It is better for the format:
> 	/* It must generate STOP before read I2DR to

Thank you for the review, but according to Documentation/CodingStyle
this multi-line comment format is only preferred for code in net/ and
drivers/net.

regards
Philipp