* [PATCH] i2c: i2c-bcm2835: match return type of wait_for_completion_timeout
@ 2015-02-08 11:04 Nicholas Mc Guire
2015-02-25 14:48 ` Lee Jones
[not found] ` <1423393458-30334-1-git-send-email-hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org>
0 siblings, 2 replies; 3+ messages in thread
From: Nicholas Mc Guire @ 2015-02-08 11:04 UTC (permalink / raw)
To: Wolfram Sang
Cc: Stephen Warren, Lee Jones, Jingoo Han, Felipe Balbi,
Uwe Kleine-Koenig, Laurent Pinchart,
linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Nicholas Mc Guire
return type of wait_for_completion_timeout is unsigned long not int. as
time_left is used for wait_for_completion_timeout exclusively here its
type is simply changed to unsigned long.
Signed-off-by: Nicholas Mc Guire <hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org>
---
Patch was only compile tested with
Patch is against 3.19.0-rc7 (localversion-next is -next-20150204)
drivers/i2c/busses/i2c-bcm2835.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
index 5d6feb9..c9336a3 100644
--- a/drivers/i2c/busses/i2c-bcm2835.c
+++ b/drivers/i2c/busses/i2c-bcm2835.c
@@ -147,7 +147,7 @@ static int bcm2835_i2c_xfer_msg(struct bcm2835_i2c_dev *i2c_dev,
struct i2c_msg *msg)
{
u32 c;
- int time_left;
+ unsigned long time_left;
i2c_dev->msg_buf = msg->buf;
i2c_dev->msg_buf_remaining = msg->len;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: i2c-bcm2835: match return type of wait_for_completion_timeout
2015-02-08 11:04 [PATCH] i2c: i2c-bcm2835: match return type of wait_for_completion_timeout Nicholas Mc Guire
@ 2015-02-25 14:48 ` Lee Jones
[not found] ` <1423393458-30334-1-git-send-email-hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org>
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2015-02-25 14:48 UTC (permalink / raw)
To: Nicholas Mc Guire
Cc: Wolfram Sang, Stephen Warren, Lee Jones, Jingoo Han, Felipe Balbi,
Uwe Kleine-Koenig, Laurent Pinchart, linux-i2c, linux-rpi-kernel,
linux-kernel
On Sun, 08 Feb 2015, Nicholas Mc Guire wrote:
> return type of wait_for_completion_timeout is unsigned long not int. as
> time_left is used for wait_for_completion_timeout exclusively here its
> type is simply changed to unsigned long.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
>
> Patch was only compile tested with
>
> Patch is against 3.19.0-rc7 (localversion-next is -next-20150204)
>
> drivers/i2c/busses/i2c-bcm2835.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
> index 5d6feb9..c9336a3 100644
> --- a/drivers/i2c/busses/i2c-bcm2835.c
> +++ b/drivers/i2c/busses/i2c-bcm2835.c
> @@ -147,7 +147,7 @@ static int bcm2835_i2c_xfer_msg(struct bcm2835_i2c_dev *i2c_dev,
> struct i2c_msg *msg)
> {
> u32 c;
> - int time_left;
> + unsigned long time_left;
>
> i2c_dev->msg_buf = msg->buf;
> i2c_dev->msg_buf_remaining = msg->len;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: i2c-bcm2835: match return type of wait_for_completion_timeout
[not found] ` <1423393458-30334-1-git-send-email-hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org>
@ 2015-03-15 9:29 ` Wolfram Sang
0 siblings, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2015-03-15 9:29 UTC (permalink / raw)
To: Nicholas Mc Guire
Cc: Stephen Warren, Lee Jones, Jingoo Han, Felipe Balbi,
Uwe Kleine-Koenig, Laurent Pinchart,
linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 385 bytes --]
On Sun, Feb 08, 2015 at 06:04:18AM -0500, Nicholas Mc Guire wrote:
> return type of wait_for_completion_timeout is unsigned long not int. as
> time_left is used for wait_for_completion_timeout exclusively here its
> type is simply changed to unsigned long.
>
> Signed-off-by: Nicholas Mc Guire <hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org>
Applied to for-next, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-15 9:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-08 11:04 [PATCH] i2c: i2c-bcm2835: match return type of wait_for_completion_timeout Nicholas Mc Guire
2015-02-25 14:48 ` Lee Jones
[not found] ` <1423393458-30334-1-git-send-email-hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org>
2015-03-15 9:29 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).