* [PATCH 2/2] i2c: nomadik: match status to return type of read_i2c
@ 2015-02-08 12:34 Nicholas Mc Guire
[not found] ` <1423398883-24687-1-git-send-email-hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Nicholas Mc Guire @ 2015-02-08 12:34 UTC (permalink / raw)
To: Alessandro Rubini
Cc: Linus Walleij, Wolfram Sang,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Nicholas Mc Guire
return type of read_i2c() is int not u32. As the assignments to status
are consistent with int here its type is changed to int.
Signed-off-by: Nicholas Mc Guire <hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org>
---
This patch depends on "[PATCH 1/2] i2c: nomadik: match return type of
wait_for_completion_timeout"
Patch was only compile tested with multi_v5_defconfig
(implies CONFIG_I2C_NOMADIK=y)
Patch is against 3.19.0-rc7 (localversion-next is -next-20150204)
drivers/i2c/busses/i2c-nomadik.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c
index 6ca6ad6..bcd17e8 100644
--- a/drivers/i2c/busses/i2c-nomadik.c
+++ b/drivers/i2c/busses/i2c-nomadik.c
@@ -446,7 +446,7 @@ static void setup_i2c_controller(struct nmk_i2c_dev *dev)
*/
static int read_i2c(struct nmk_i2c_dev *dev, u16 flags)
{
- u32 status = 0;
+ int status = 0;
u32 mcr, irq_mask;
unsigned long timeout;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1423398883-24687-1-git-send-email-hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org>]
* Re: [PATCH 2/2] i2c: nomadik: match status to return type of read_i2c [not found] ` <1423398883-24687-1-git-send-email-hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org> @ 2015-03-04 12:56 ` Linus Walleij 2015-03-15 10:02 ` Wolfram Sang 1 sibling, 0 replies; 3+ messages in thread From: Linus Walleij @ 2015-03-04 12:56 UTC (permalink / raw) To: Nicholas Mc Guire Cc: Alessandro Rubini, Wolfram Sang, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Sun, Feb 8, 2015 at 1:34 PM, Nicholas Mc Guire <hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org> wrote: > return type of read_i2c() is int not u32. As the assignments to status > are consistent with int here its type is changed to int. > > Signed-off-by: Nicholas Mc Guire <hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org> Acked-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Yours, Linus Walleij ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] i2c: nomadik: match status to return type of read_i2c [not found] ` <1423398883-24687-1-git-send-email-hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org> 2015-03-04 12:56 ` Linus Walleij @ 2015-03-15 10:02 ` Wolfram Sang 1 sibling, 0 replies; 3+ messages in thread From: Wolfram Sang @ 2015-03-15 10:02 UTC (permalink / raw) To: Nicholas Mc Guire Cc: Alessandro Rubini, Linus Walleij, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-i2c-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 325 bytes --] On Sun, Feb 08, 2015 at 07:34:43AM -0500, Nicholas Mc Guire wrote: > return type of read_i2c() is int not u32. As the assignments to status > are consistent with int here its type is changed to int. > > Signed-off-by: Nicholas Mc Guire <hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org> Applied to for-next, thanks! [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-15 10:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-08 12:34 [PATCH 2/2] i2c: nomadik: match status to return type of read_i2c Nicholas Mc Guire
[not found] ` <1423398883-24687-1-git-send-email-hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org>
2015-03-04 12:56 ` Linus Walleij
2015-03-15 10:02 ` Wolfram Sang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).