From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Subject: [PATCH] i2c: designware: Suppress error message if platform_get_irq() returns -EPROBE_DEFER Date: Tue, 3 Mar 2015 18:27:36 +0300 Message-ID: <1425396456-10633-1-git-send-email-abrodkin@synopsys.com> Return-path: Sender: linux-kernel-owner@vger.kernel.org To: linux-i2c@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexey Brodkin , Vineet Gupta , Christian Ruppert , Mika Westerberg , Wolfram Sang List-Id: linux-i2c@vger.kernel.org There's no point in printing error message if platform_get_irq() returns -EPROBE_DEFER because probe deferring subsystem already outputs message in bootlog like this: --->8--- platform e001d000.i2c: Driver i2c_designware requests probe deferral --->8--- Moreover in case of probe deferral following message may mislead user: --->8--- i2c_designware e001d000.i2c: no irq resource? --->8--- even though it's expected that platform_get_irq() may return -EPROBE_DEFER. Signed-off-by: Alexey Brodkin Cc: Vineet Gupta Cc: Christian Ruppert Cc: Mika Westerberg Cc: Wolfram Sang --- drivers/i2c/busses/i2c-designware-platdrv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c index c270f5f..01c1b17 100644 --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -144,7 +144,8 @@ static int dw_i2c_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) { - dev_err(&pdev->dev, "no irq resource?\n"); + if (irq != -EPROBE_DEFER) + dev_err(&pdev->dev, "no irq resource?\n"); return irq; /* -ENXIO */ } -- 2.1.0