From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Bolle Subject: Re: [PATCH 1/2] i2c_imc: New driver for Intel's iMC, found on LGA2011 chips Date: Sat, 07 Mar 2015 13:48:27 +0100 Message-ID: <1425732507.2281.12.camel@tiscali.nl> References: <13443f0542fb447a4c0e558a5f6077c6a76a6e95.1425695891.git.luto@amacapital.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <13443f0542fb447a4c0e558a5f6077c6a76a6e95.1425695891.git.luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andy Lutomirski Cc: Wolfram Sang , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jean Delvare , Guenter Roeck , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mauro Carvalho Chehab , Rui Wang , Tony Luck , One Thousand Gnomes , Alun Evans , Robert Elliott , Boaz Harrosh List-Id: linux-i2c@vger.kernel.org Just two nits. Andy Lutomirski schreef op vr 06-03-2015 om 18:50 [-0800]: > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -149,6 +149,24 @@ config I2C_ISMT > This driver can also be built as a module. If so, the module will be > called i2c-ismt. > > +config I2C_IMC > + tristate "Intel iMC (LGA 2011) SMBus Controller" > + depends on PCI && X86 > + select I2C_DIMM_BUS The pedant in me can't help but notice that I2C_DIMM_BUS itself is added in patch 2/2. And so is the call of i2c_scan_dimm_bus() in i2c-imc.c that apparently requires this select. So that select isn't really needed in this patch but in 2/2. > + help > + If you say yes to this option, support will be included for the Intel > + Integrated Memory Controller SMBus host controller interface. This > + controller is found on LGA 2011 Xeons and Core i7 Extremes. > + > + There are currently no systems on which the kernel knows that it can > + safely enable this driver. For now, you need to pass this driver a > + scary module parameter, and you should only pass that parameter if you > + have a special motherboard and know exactly what you are doing. > + Special motherboards include the Supermicro X9DRH-iF-NV. > + > + This driver can also be built as a module. If so, the module will be > + called i2c-imc. > + > config I2C_PIIX4 > tristate "Intel PIIX4 and compatible (ATI/AMD/Serverworks/Broadcom/SMSC)" > depends on PCI > --- /dev/null > +++ b/drivers/i2c/busses/i2c-imc.c > @@ -0,0 +1,583 @@ > +/* > + * Copyright (c) 2013 Andrew Lutomirski > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 > + * as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. > + */ This states the license is GPL v2. > +MODULE_LICENSE("GPL"); So you probably want to use MODULE_LICENSE("GPL v2"); here. Paul Bolle