linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org>
To: Andy Lutomirski <luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>
Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
	Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Mauro Carvalho Chehab
	<m.chehab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Rui Wang <ruiv.wang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Tony Luck <tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	One Thousand Gnomes
	<gnomes-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>,
	Alun Evans <alun-eX+YDEU5biwsV2N9l4h3zg@public.gmane.org>,
	Robert Elliott <Elliott-VXdhtT5mjnY@public.gmane.org>,
	Boaz Harrosh <boaz-/8YdC2HfS5554TAoqtyWWQ@public.gmane.org>
Subject: Re: [PATCH 2/2] i2c, i2c_imc: Add DIMM bus code
Date: Sat, 07 Mar 2015 13:51:10 +0100	[thread overview]
Message-ID: <1425732670.2281.14.camel@tiscali.nl> (raw)
In-Reply-To: <4ec9e7471354b350936ffa75e94125b169d14690.1425695891.git.luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>

Just a license nit, I'm afraid.

Andy Lutomirski schreef op vr 06-03-2015 om 18:50 [-0800]:
> --- /dev/null
> +++ b/drivers/i2c/busses/dimm-bus.c
> @@ -0,0 +1,97 @@
> +/*
> + * Copyright (c) 2013 Andrew Lutomirski <luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2
> + * as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
> + */

This states the license is GPL v2.

> +MODULE_LICENSE("GPL");

So you probably want
    MODULE_LICENSE("GPL v2");

here too.


Paul Bolle

  parent reply	other threads:[~2015-03-07 12:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-07  2:50 [PATCH 0/2] i2c_imc: New driver, at long last Andy Lutomirski
2015-03-07  2:50 ` [PATCH 1/2] i2c_imc: New driver for Intel's iMC, found on LGA2011 chips Andy Lutomirski
     [not found]   ` <13443f0542fb447a4c0e558a5f6077c6a76a6e95.1425695891.git.luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>
2015-03-07 12:48     ` Paul Bolle
2015-03-07 14:38   ` Guenter Roeck
2015-03-08 14:03     ` Andy Lutomirski
2015-03-08 15:39       ` Guenter Roeck
     [not found]         ` <54FC6D2B.3060307-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-03-08 19:30           ` Andy Lutomirski
2015-03-08 19:50             ` Guenter Roeck
     [not found]               ` <54FCA807.7080505-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-03-08 19:55                 ` Andy Lutomirski
2015-03-07  2:50 ` [PATCH 2/2] i2c, i2c_imc: Add DIMM bus code Andy Lutomirski
     [not found]   ` <4ec9e7471354b350936ffa75e94125b169d14690.1425695891.git.luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>
2015-03-07 12:51     ` Paul Bolle [this message]
2015-03-07 16:03   ` Guenter Roeck
     [not found]     ` <54FB2154.7000701-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-03-08 14:09       ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425732670.2281.14.camel@tiscali.nl \
    --to=pebolle-iwqwacnznjzz+pzb47itoq@public.gmane.org \
    --cc=Elliott-VXdhtT5mjnY@public.gmane.org \
    --cc=alun-eX+YDEU5biwsV2N9l4h3zg@public.gmane.org \
    --cc=boaz-/8YdC2HfS5554TAoqtyWWQ@public.gmane.org \
    --cc=gnomes-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org \
    --cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
    --cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org \
    --cc=m.chehab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=ruiv.wang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).