From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Subject: [PATCH v2] i2c: designware: Suppress error message if platform_get_irq() < 0 Date: Mon, 9 Mar 2015 12:03:12 +0300 Message-ID: <1425891792-9248-1-git-send-email-abrodkin@synopsys.com> Return-path: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alexey Brodkin , Vineet Gupta , Christian Ruppert , Mika Westerberg , Wolfram Sang , Andy Shevchenko List-Id: linux-i2c@vger.kernel.org As discussed here https://lkml.org/lkml/2015/3/3/568 and here https://lkml.org/lkml/2015/3/3/453 we're looking forward for implementing warnings and errors outputs right in platform_get_irq() instead of having all kind of different outputs in each and every driver that uses platform_get_irq(). Signed-off-by: Alexey Brodkin Cc: Vineet Gupta Cc: Christian Ruppert Cc: Mika Westerberg Cc: Wolfram Sang Cc: Andy Shevchenko --- drivers/i2c/busses/i2c-designware-platdrv.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c index c270f5f..fa4e2b5 100644 --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -143,10 +143,8 @@ static int dw_i2c_probe(struct platform_device *pdev) u32 clk_freq, ht = 0; irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "no irq resource?\n"); - return irq; /* -ENXIO */ - } + if (irq < 0) + return irq; dev = devm_kzalloc(&pdev->dev, sizeof(struct dw_i2c_dev), GFP_KERNEL); if (!dev) -- 2.1.0