[PATCH] i2c: jz4780: Explicitly include linux/io.h

[PATCH] i2c: jz4780: Explicitly include linux/io.h

[Mark Brown]

This driver uses readw() and writew() which are declared in asm/io.h but
does not explicitly include that header, causing build failures on
architectures where there is not an implicit inclusion such as arm and
arm64:

../drivers/i2c/busses/i2c-jz4780.c:181:2: error: implicit declaration of function 'readw' [-Werror=implicit-function-declaration]
../drivers/i2c/busses/i2c-jz4780.c:187:2: error: implicit declaration of function 'writew' [-Werror=implicit-function-declaration]

Add an explicit inclusion to fix this.

Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
 drivers/i2c/busses/i2c-jz4780.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-jz4780.c b/drivers/i2c/busses/i2c-jz4780.c
index ce1d69324169..19b2d689a5ef 100644
--- a/drivers/i2c/busses/i2c-jz4780.c
+++ b/drivers/i2c/busses/i2c-jz4780.c
@@ -23,6 +23,7 @@
 #include <linux/i2c.h>
 #include <linux/init.h>
 #include <linux/interrupt.h>
+#include <linux/io.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
-- 
2.1.4

Re: [PATCH] i2c: jz4780: Explicitly include linux/io.h

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 760 bytes --]

On Wed, Apr 15, 2015 at 07:08:11PM +0100, Mark Brown wrote:
> This driver uses readw() and writew() which are declared in asm/io.h but
> does not explicitly include that header, causing build failures on
> architectures where there is not an implicit inclusion such as arm and
> arm64:
> 
> ../drivers/i2c/busses/i2c-jz4780.c:181:2: error: implicit declaration of function 'readw' [-Werror=implicit-function-declaration]
> ../drivers/i2c/busses/i2c-jz4780.c:187:2: error: implicit declaration of function 'writew' [-Werror=implicit-function-declaration]
> 
> Add an explicit inclusion to fix this.
> 
> Signed-off-by: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

Thanks, I just pushed the same fix from Guenter Roeck to -next.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]