[PATCH] i2c: st: add include for pinctrl

[PATCH] i2c: st: add include for pinctrl

[Wolfram Sang]

The driver uses pinctrl directly and thus should include the appropriate
header. Sort the headers while we are here to have a better view what is
included and what is not.

Reported-by: Pascal Huerst <pascal.huerst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
---
 drivers/i2c/busses/i2c-st.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c
index 88057fad9dfef4..d525769db5c3d5 100644
--- a/drivers/i2c/busses/i2c-st.c
+++ b/drivers/i2c/busses/i2c-st.c
@@ -10,17 +10,18 @@
  * published by the Free Software Foundation.
  */
 
-#include <linux/module.h>
-#include <linux/platform_device.h>
-#include <linux/i2c.h>
 #include <linux/clk.h>
-#include <linux/io.h>
 #include <linux/delay.h>
-#include <linux/interrupt.h>
 #include <linux/err.h>
-#include <linux/of.h>
+#include <linux/i2c.h>
+#include <linux/interrupt.h>
+#include <linux/io.h>
+#include <linux/module.h>
 #include <linux/of_address.h>
+#include <linux/of.h>
 #include <linux/of_irq.h>
+#include <linux/pinctrl/consumer.h>
+#include <linux/platform_device.h>
 
 /* SSC registers */
 #define SSC_BRG				0x000
-- 
2.1.4

Re: [PATCH] i2c: st: add include for pinctrl

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

On Thu, Apr 23, 2015 at 01:42:02PM +0200, Wolfram Sang wrote:
> The driver uses pinctrl directly and thus should include the appropriate
> header. Sort the headers while we are here to have a better view what is
> included and what is not.
> 
> Reported-by: Pascal Huerst <pascal.huerst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>

Improved the sorting some more and applied to for-current, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] i2c: st: add include for pinctrl

[Maxime Coquelin]

On 04/23/2015 06:33 PM, Wolfram Sang wrote:
> On Thu, Apr 23, 2015 at 01:42:02PM +0200, Wolfram Sang wrote:
>> The driver uses pinctrl directly and thus should include the appropriate
>> header. Sort the headers while we are here to have a better view what is
>> included and what is not.
>>
>> Reported-by: Pascal Huerst <pascal.huerst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> Signed-off-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
> Improved the sorting some more and applied to for-current, thanks!
>

Thanks Wolfram.