linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Silvan Wicki <linux_wi-ADq4ffItWIY@public.gmane.org>
To: wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Silvan Wicki <linux_wi-ADq4ffItWIY@public.gmane.org>
Subject: [PATCH v2] i2c: i2c-bcm2708: fixes cdiv uneven number
Date: Fri,  1 May 2015 23:43:49 +0200	[thread overview]
Message-ID: <1430516629-32692-1-git-send-email-linux_wi@tinag.ch> (raw)

Prevents that cdiv can be an uneven number as per datasheet cdiv is
always rounded down to an even number.

Datasheet at page 34 on
http://www.raspberrypi.org/wp-content/uploads/2012/02/BCM2835-ARM-Peripherals.pdf

Signed-off-by: Silvan Wicki <linux_wi-ADq4ffItWIY@public.gmane.org>
---
 drivers/i2c/busses/i2c-bcm2708.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-bcm2708.c b/drivers/i2c/busses/i2c-bcm2708.c
index 81e9374..dd7094a 100644
--- a/drivers/i2c/busses/i2c-bcm2708.c
+++ b/drivers/i2c/busses/i2c-bcm2708.c
@@ -67,6 +67,9 @@
 #define BSC_S_DONE		0x00000002
 #define BSC_S_TA		0x00000001
 
+#define BSC_CDIV_MAX		0xFFFE
+#define BSC_CDIV_BITMASK	0xFFFE
+
 #define I2C_TIMEOUT_MS	150
 #define I2C_WAIT_LOOP_COUNT 40
 
@@ -441,9 +444,15 @@ static int bcm2708_i2c_probe(struct platform_device *pdev)
 
 	bus_hz = clk_get_rate(bi->clk);
 	cdiv = bus_hz / baudrate;
-	if (cdiv > 0xffff) {
-		cdiv = 0xffff;
+	/* as per datasheet cdiv is always rounded down to an even number */
+	if (cdiv > BSC_CDIV_MAX) {
+		cdiv = BSC_CDIV_MAX;
 		baudrate = bus_hz / cdiv;
+	} else {
+		if ((cdiv & BSC_CDIV_BITMASK) != cdiv) {
+			cdiv &= BSC_CDIV_BITMASK;
+			baudrate = bus_hz / cdiv;
+		}
 	}
 	bi->cdiv = cdiv;
 
-- 
2.1.4

             reply	other threads:[~2015-05-01 21:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-01 21:43 Silvan Wicki [this message]
     [not found] ` <1430516629-32692-1-git-send-email-linux_wi-ADq4ffItWIY@public.gmane.org>
2015-05-04  4:50   ` [PATCH v2] i2c: i2c-bcm2708: fixes cdiv uneven number rajeev kumar
     [not found]     ` <CAA7nrtgTOg0YBKavBhV+=9fvxxjtd143aODZpfR=TSN7STrrXg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-06 18:35       ` Silvan Wicki
2015-05-12 15:54   ` wsa-z923LK4zBo2bacvFa/9K2g

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430516629-32692-1-git-send-email-linux_wi@tinag.ch \
    --to=linux_wi-adq4ffitwiy@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).