From: Vasily Khoruzhick <anarsoul@gmail.com>
To: Kukjin Kim <kgene@kernel.org>, Wolfram Sang <wsa@the-dreams.de>,
linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org
Cc: Vasily Khoruzhick <anarsoul@gmail.com>
Subject: [PATCH] i2c: s3c2410: fix oops in suspend callback for non-dt platforms
Date: Sun, 3 May 2015 21:13:10 +0300 [thread overview]
Message-ID: <1430676790-30500-1-git-send-email-anarsoul@gmail.com> (raw)
Initialize sysreg by default, otherwise driver will crash in suspend callback.
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
drivers/i2c/busses/i2c-s3c2410.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index 958c8db..297e9c9 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -1143,6 +1143,7 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
return -ENOMEM;
i2c->quirks = s3c24xx_get_device_quirks(pdev);
+ i2c->sysreg = ERR_PTR(-ENOENT);
if (pdata)
memcpy(i2c->pdata, pdata, sizeof(*pdata));
else
--
2.3.5
next reply other threads:[~2015-05-03 18:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-03 18:13 Vasily Khoruzhick [this message]
2015-05-03 23:50 ` [PATCH] i2c: s3c2410: fix oops in suspend callback for non-dt platforms Krzysztof Kozlowski
[not found] ` <CAJKOXPd71vnup-RZYAh7UM2Tky2M64tA=u0Ydy=ti0yOC6h5aQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-04 17:52 ` Vasily Khoruzhick
[not found] ` <CA+E=qVdjvx=0PSh-ead_pABd9D=bG3ua1FFRTSN2U5BVf2a=Og-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-05 1:46 ` Krzysztof Kozlowski
2015-05-05 21:28 ` Kukjin Kim
2015-05-05 21:30 ` Kukjin Kim
[not found] ` <1430676790-30500-1-git-send-email-anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-12 16:15 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430676790-30500-1-git-send-email-anarsoul@gmail.com \
--to=anarsoul@gmail.com \
--cc=kgene@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).