From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH] i2c: powermac: don't workaround for keywest Date: Mon, 11 May 2015 08:14:47 +1000 Message-ID: <1431296087.13039.13.camel@kernel.crashing.org> References: <1431192213-2904-1-git-send-email-wsa@the-dreams.de> <20150510183431.GA1510@katana> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150510183431.GA1510@katana> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfram Sang Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Dan DeVoto , Mark Elliott List-Id: linux-i2c@vger.kernel.org On Sun, 2015-05-10 at 20:34 +0200, Wolfram Sang wrote: > Okay, so this patch is bogus. I understand now that onyx uses another > codec than TAS, so this change will regress on other machines. > However, > it shows that this unconditional instantiation of the TAS breaks sound > on Macintoshs which still need non-aoa sound support. I assume there > will be noone in the near future to convert Keywest to AOA, so we'll > need to find a hackish way around this instantiation problem. Converting the old macs that use TAS shouldn't be *that* hard, main problem is I don't have the hardware to test... Ben.