linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vaibhav Hiremath <vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Vaibhav Hiremath
	<vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"Jett.Zhou" <jtzhou-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
Subject: [PATCH 10/12] i2c: pxa: Update debug function to dump more info on error
Date: Thu, 28 May 2015 18:33:42 +0530	[thread overview]
Message-ID: <1432818224-17070-11-git-send-email-vaibhav.hiremath@linaro.org> (raw)
In-Reply-To: <1432818224-17070-1-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Update i2c_pxa_scream_blue_murder() fn to print more information
in case of error.

Signed-off-by: Jett.Zhou <jtzhou-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
[vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org: Split patches into logical changes
and update the Changelog]
Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>

Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
 drivers/i2c/busses/i2c-pxa.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index cf6c383..065e647 100644
--- a/drivers/i2c/busses/i2c-pxa.c
+++ b/drivers/i2c/busses/i2c-pxa.c
@@ -147,6 +147,7 @@ struct pxa_i2c {
 	unsigned int		msg_idx;
 	unsigned int		msg_ptr;
 	unsigned int		slave_addr;
+	unsigned int		req_slave_addr;
 
 	struct i2c_adapter	adap;
 	struct clk		*clk;
@@ -335,11 +336,13 @@ err_out:
 static void i2c_pxa_scream_blue_murder(struct pxa_i2c *i2c, const char *why)
 {
 	unsigned int i;
-	printk(KERN_ERR "i2c: error: %s\n", why);
+	printk(KERN_ERR"i2c: <%s> slave_0x%x error: %s\n", i2c->adap.name,
+		i2c->req_slave_addr >> 1, why);
 	printk(KERN_ERR "i2c: msg_num: %d msg_idx: %d msg_ptr: %d\n",
 		i2c->msg_num, i2c->msg_idx, i2c->msg_ptr);
-	printk(KERN_ERR "i2c: ICR: %08x ISR: %08x\n",
-	       readl(_ICR(i2c)), readl(_ISR(i2c)));
+	printk(KERN_ERR "i2c: IBMR: %08x IDBR: %08x ICR: %08x ISR: %08x\n",
+		readl(_IBMR(i2c)), readl(_IDBR(i2c)), readl(_ICR(i2c)),
+		readl(_ISR(i2c)));
 	printk(KERN_DEBUG "i2c: log: ");
 	for (i = 0; i < i2c->irqlogidx; i++)
 		printk("[%08x:%08x] ", i2c->isrlog[i], i2c->icrlog[i]);
@@ -736,6 +739,7 @@ static inline void i2c_pxa_start_message(struct pxa_i2c *i2c)
 	 * Step 1: target slave address into IDBR
 	 */
 	writel(i2c_pxa_addr_byte(i2c->msg), _IDBR(i2c));
+	i2c->req_slave_addr = i2c_pxa_addr_byte(i2c->msg);
 
 	/*
 	 * Step 2: initiate the write.
@@ -1055,6 +1059,7 @@ static void i2c_pxa_irq_txempty(struct pxa_i2c *i2c, u32 isr)
 		 * Write the next address.
 		 */
 		writel(i2c_pxa_addr_byte(i2c->msg), _IDBR(i2c));
+		i2c->req_slave_addr = i2c_pxa_addr_byte(i2c->msg);
 
 		/*
 		 * And trigger a repeated start, and send the byte.
-- 
1.9.1

  parent reply	other threads:[~2015-05-28 13:03 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-28 13:03 [PATCH 00/12] i2c: pxa: Fixes, cleanup and support for pxa910 family Vaibhav Hiremath
     [not found] ` <1432818224-17070-1-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-05-28 13:03   ` [PATCH 01/12] i2c: pxa: keep i2c irq ON in suspend Vaibhav Hiremath
2015-05-28 13:03   ` [PATCH 02/12] i2c: pxa: No need to set slave addr for i2c master mode reset Vaibhav Hiremath
2015-05-29 19:21     ` Robert Jarzmik
     [not found]       ` <87d21jyyua.fsf-4ty26DBLk+jEm7gnYqmdkQ@public.gmane.org>
2015-05-29 19:25         ` Vaibhav Hiremath
2015-05-28 13:03   ` [PATCH 03/12] i2c: pxa: Add reset operation when i2c bus busy Vaibhav Hiremath
     [not found]     ` <1432818224-17070-4-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-05-29 19:39       ` Robert Jarzmik
     [not found]         ` <878uc7yxzx.fsf-4ty26DBLk+jEm7gnYqmdkQ@public.gmane.org>
2015-05-29 20:20           ` Vaibhav Hiremath
2015-05-28 13:03   ` [PATCH 04/12] i2c: pxa: Add support for pxa910/988 & new configuration features Vaibhav Hiremath
     [not found]     ` <1432818224-17070-5-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-05-29 20:22       ` Robert Jarzmik
     [not found]         ` <874mmvyvzw.fsf-4ty26DBLk+jEm7gnYqmdkQ@public.gmane.org>
2015-05-29 20:33           ` Vaibhav Hiremath
2015-06-04  2:31         ` Yi Zhang
2015-06-04  5:46           ` Vaibhav Hiremath
2015-06-01  0:13       ` Wolfram Sang
     [not found]         ` <4edfb7fe9edf4800e73c86a258fe4fd1-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-06-02  5:01           ` Vaibhav Hiremath
2015-05-28 13:03   ` [PATCH 05/12] i2c: pxa: Add bus reset functionality Vaibhav Hiremath
     [not found]     ` <1432818224-17070-6-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-05-29 13:59       ` Rob Herring
     [not found]         ` <CAL_Jsq+-u7pf7JOXD7frB-ye9bk0NLAKhAJFvLYz1a1jzOCb9Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-29 15:40           ` Vaibhav Hiremath
2015-05-29 20:31       ` Robert Jarzmik
2015-06-02 13:12       ` Linus Walleij
     [not found]         ` <CACRpkdaxWsi8t6aUFJK-KCmQF1gEOLiOE8=fgDRxQDSi4G6FgQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-02 16:40           ` Vaibhav Hiremath
2015-06-03 19:16           ` Vaibhav Hiremath
2015-06-02 17:33       ` Wolfram Sang
2015-06-02 17:40         ` Vaibhav Hiremath
     [not found]           ` <556DEA90.3010001-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-06-02 17:48             ` Wolfram Sang
2015-06-02 17:57               ` Vaibhav Hiremath
     [not found]                 ` <556DEE6C.1060300-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-06-02 18:02                   ` Wolfram Sang
2015-06-02 18:06                     ` Vaibhav Hiremath
     [not found]                       ` <556DF0A0.30807-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-06-02 18:24                         ` Wolfram Sang
2015-06-02 18:46                           ` Vaibhav Hiremath
2015-05-28 13:03   ` [PATCH 06/12] i2c: pxa: Return I2C_RETRY when timeout in pio mode Vaibhav Hiremath
     [not found]     ` <1432818224-17070-7-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-05-29 20:46       ` Robert Jarzmik
     [not found]         ` <87vbfbxgb0.fsf-4ty26DBLk+jEm7gnYqmdkQ@public.gmane.org>
2015-05-29 21:23           ` Vaibhav Hiremath
2015-05-28 13:03   ` [PATCH 07/12] i2c: pxa: Reset i2c controller on timeout in interrupt and " Vaibhav Hiremath
     [not found]     ` <1432818224-17070-8-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-05-29 21:13       ` Robert Jarzmik
     [not found]         ` <87r3pzxf1s.fsf-4ty26DBLk+jEm7gnYqmdkQ@public.gmane.org>
2015-05-29 21:19           ` Vaibhav Hiremath
2015-05-28 13:03   ` [PATCH 08/12] i2c: pxa: enable/disable irq across message xfer Vaibhav Hiremath
     [not found]     ` <1432818224-17070-9-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-05-28 13:17       ` Russell King - ARM Linux
     [not found]         ` <20150528131707.GB2067-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2015-05-28 13:29           ` Vaibhav Hiremath
2015-05-28 13:03   ` [PATCH 09/12] i2c: pxa: Remove compile warnning in 64bit mode Vaibhav Hiremath
     [not found]     ` <1432818224-17070-10-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-05-29 21:28       ` Robert Jarzmik
2015-05-28 13:03   ` Vaibhav Hiremath [this message]
     [not found]     ` <1432818224-17070-11-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-05-29 21:42       ` [PATCH 10/12] i2c: pxa: Update debug function to dump more info on error Robert Jarzmik
     [not found]         ` <87fv6fxdqu.fsf-4ty26DBLk+jEm7gnYqmdkQ@public.gmane.org>
2015-05-29 21:45           ` Vaibhav Hiremath
2015-05-28 13:03   ` [PATCH 11/12] i2c:pxa: Use devm_ variants in probe function Vaibhav Hiremath
     [not found]     ` <1432818224-17070-12-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-05-30 15:53       ` Robert Jarzmik
     [not found]         ` <878uc6xdsd.fsf-4ty26DBLk+jEm7gnYqmdkQ@public.gmane.org>
2015-05-31  7:36           ` Vaibhav Hiremath
2015-05-28 13:03   ` [PATCH 12/12] i2c: pxa: enable/disable i2c module across msg xfer Vaibhav Hiremath
     [not found]     ` <1432818224-17070-13-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-05-28 13:23       ` Russell King - ARM Linux
     [not found]         ` <20150528132312.GC2067-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2015-06-02 16:52           ` Vaibhav Hiremath
     [not found]             ` <556DDF43.4050804-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-06-02 16:59               ` Vaibhav Hiremath
     [not found]                 ` <556DE0EB.1010609-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-06-03 10:56                   ` Yi Zhang
2015-06-03 18:49                     ` Vaibhav Hiremath
2015-06-04  6:29                   ` Yi Zhang
2015-06-04  7:19                     ` Vaibhav Hiremath
     [not found]                       ` <556FFC14.3050901-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-06-04  7:58                         ` Yi Zhang
2015-06-01  0:07   ` [PATCH 00/12] i2c: pxa: Fixes, cleanup and support for pxa910 family Wolfram Sang
     [not found]     ` <fb192019ec75e9aa10b04b79e87a6e79-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-06-02  4:58       ` Vaibhav Hiremath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432818224-17070-11-git-send-email-vaibhav.hiremath@linaro.org \
    --to=vaibhav.hiremath-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
    --cc=jtzhou-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).