From: Shubhrajyoti Datta <shubhrajyoti.datta-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Shubhrajyoti Datta <shubhraj-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH 2/9] i2c: xiic: Remove the disabling of interrupts
Date: Mon, 15 Jun 2015 20:47:53 +0530 [thread overview]
Message-ID: <1434381480-3042-2-git-send-email-shubhraj@xilinx.com> (raw)
In-Reply-To: <1434381480-3042-1-git-send-email-shubhraj-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
Currently the interrupts are disabled at the start of the
isr and enabled at the end of the isr. Remove the same.
Signed-off-by: Shubhrajyoti Datta <shubhraj-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
---
drivers/i2c/busses/i2c-xiic.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
index cea842e..ce6b856 100644
--- a/drivers/i2c/busses/i2c-xiic.c
+++ b/drivers/i2c/busses/i2c-xiic.c
@@ -606,14 +606,11 @@ static irqreturn_t xiic_isr(int irq, void *dev_id)
struct xiic_i2c *i2c = dev_id;
spin_lock(&i2c->lock);
- /* disable interrupts globally */
- xiic_setreg32(i2c, XIIC_DGIER_OFFSET, 0);
dev_dbg(i2c->adap.dev.parent, "%s entry\n", __func__);
xiic_process(i2c);
- xiic_setreg32(i2c, XIIC_DGIER_OFFSET, XIIC_GINTR_ENABLE_MASK);
spin_unlock(&i2c->lock);
return IRQ_HANDLED;
--
1.7.1
next prev parent reply other threads:[~2015-06-15 15:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 15:17 [PATCH 1/9] i2c: xiic: Do not continue in case of errors in Rx Shubhrajyoti Datta
[not found] ` <1434381480-3042-1-git-send-email-shubhraj-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2015-06-15 15:17 ` Shubhrajyoti Datta [this message]
2015-06-15 15:17 ` [PATCH 3/9] i2c: xiic: move the xiic_process to thread context Shubhrajyoti Datta
2015-06-15 15:17 ` [PATCH 4/9] i2c: xiic: Do not reset controller before every transfer Shubhrajyoti Datta
2015-06-15 15:17 ` [PATCH 5/9] i2c: xiic: Remove the disabling of interrupts Shubhrajyoti Datta
2015-06-15 15:17 ` [PATCH 6/9] i2c: xiic: Remove busy loop while waiting for bus busy Shubhrajyoti Datta
2015-06-15 15:17 ` [PATCH 7/9] i2c: xiic: Add a msg in case of timeout Shubhrajyoti Datta
2015-06-15 15:17 ` [PATCH 8/9] i2c: xiic: Remove the Addressed as slave interrupt Shubhrajyoti Datta
2015-06-15 15:18 ` [PATCH 9/9] i2c: xiic: Service all interrupts in isr Shubhrajyoti Datta
2015-06-17 11:42 ` [PATCH 1/9] i2c: xiic: Do not continue in case of errors in Rx Wolfram Sang
[not found] ` <20150617114159.GA4604-oo5tB6JMkjKRinMKxDlMNPwbnWRJjS81@public.gmane.org>
2015-06-17 12:38 ` Shubhrajyoti Datta
[not found] ` <4EED9C67BE3EF440A606099F8E34C52862BB72-4lKfpRxZ5enZMOc0yg5rMog+Gb3gawCHQz34XiSyOiE@public.gmane.org>
2015-06-17 12:44 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434381480-3042-2-git-send-email-shubhraj@xilinx.com \
--to=shubhrajyoti.datta-gjffaj9ahvfqt0dzr+alfa@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shubhraj-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).