Re: [Patch v1] i2c: imx: implement bus recovery

["Jan Lübbe" <jlu-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

On Di, 2015-07-14 at 08:12 +0000, Gao Pandy wrote:
> > > --- a/Documentation/devicetree/bindings/i2c/i2c-imx.txt
> > > +++ b/Documentation/devicetree/bindings/i2c/i2c-imx.txt
> > > @@ -14,6 +14,8 @@ Optional properties:
> > >    The absence of the propoerty indicates the default frequency
> 100 kHz.
> > >  - dmas: A list of two dma specifiers, one for each entry in
> dma-names.
> > >  - dma-names: should contain "tx" and "rx".
> > > +- recover-scl: specify the gpio related to SCL pin
> > > +- recover-sda: specify the gpio related to SDA pin
> > I don't like the naming here. That the gpios are used for recovery
> isn't
> > a hardware description. What about "scl-gpio" and "sda-gpio"?
> 
> Thanks. I will change it in the next version. 

There is already a binding for i2c-gpio:
Documentation/devicetree/bindings/i2c/i2c-gpio.txt

We should be able to reuse those properties as-is, instead of defining
something for each i2c controller binding.

Regards,
Jan
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |