From: Fugang Duan <b38611-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Frank.Li-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
b38611-KZfg59tc24xl57MIdRCFDg@public.gmane.org
Subject: [PATCH] i2c: imx: change dev_info to dev_dbg to reduce dummy log
Date: Mon, 27 Jul 2015 16:26:55 +0800 [thread overview]
Message-ID: <1437985615-30791-1-git-send-email-b38611@freescale.com> (raw)
For most of imx platforms, there have no DMA support for I2C bus.
So, by default, there is only cpu mode.
The current driver to check whether there have DMA channel config in
dts file to judge whether it support DMA mode or not, if doesn't config
it print out "can't use DMA" for each bus during probe.
kernel boot up log:
i2c i2c-0: IMX I2C adapter registered
i2c i2c-0: can't use DMA
i2c i2c-1: IMX I2C adapter registered
i2c i2c-1: can't use DMA
i2c i2c-2: IMX I2C adapter registered
i2c i2c-2: can't use DMA
i2c i2c-3: IMX I2C adapter registered
i2c i2c-3: can't use DMA
It is very ugly and confused. So change the dev_info() to deb_dbg() to
avoid print dummy and redundant log.
Signed-off-by: Fugang Duan <B38611-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
---
drivers/i2c/busses/i2c-imx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index 785aa67..28fba91 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -339,7 +339,7 @@ fail_tx:
dma_release_channel(dma->chan_tx);
fail_al:
devm_kfree(dev, dma);
- dev_info(dev, "can't use DMA\n");
+ dev_dbg(dev, "can't use DMA\n");
}
static void i2c_imx_dma_callback(void *arg)
--
1.9.1
next reply other threads:[~2015-07-27 8:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 8:26 Fugang Duan [this message]
[not found] ` <1437985615-30791-1-git-send-email-b38611-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-07-31 11:04 ` [PATCH] i2c: imx: change dev_info to dev_dbg to reduce dummy log Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437985615-30791-1-git-send-email-b38611@freescale.com \
--to=b38611-kzfg59tc24xl57midrcfdg@public.gmane.org \
--cc=Frank.Li-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).