From: Wolfram Sang <wsa@the-dreams.de>
To: linux-i2c@vger.kernel.org
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Wolfram Sang <wsa@the-dreams.de>,
Andrey Danin <danindrey@mail.ru>,
Stephen Warren <swarren@wwwdotorg.org>,
Stephen Warren <swarren@nvidia.com>
Subject: [PATCH 06/10] i2c: apply DT flags when probing
Date: Sat, 8 Aug 2015 22:33:23 +0200 [thread overview]
Message-ID: <1439066007-13951-7-git-send-email-wsa@the-dreams.de> (raw)
In-Reply-To: <1439066007-13951-1-git-send-email-wsa@the-dreams.de>
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
Check for slave and 10-bit flags when probing and mark the client when
found. Improve the address validity check, too
Tested-by: Andrey Danin <danindrey@mail.ru>
Acked-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/i2c/i2c-core.c | 23 ++++++++++++++++++-----
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 4a83d39a5aabe2..7638eb1a5998f8 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -27,6 +27,7 @@
I2C slave support (c) 2014 by Wolfram Sang <wsa@sang-engineering.com>
*/
+#include <dt-bindings/i2c/i2c.h>
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/delay.h>
@@ -1286,7 +1287,8 @@ static struct i2c_client *of_i2c_register_device(struct i2c_adapter *adap,
struct i2c_client *result;
struct i2c_board_info info = {};
struct dev_archdata dev_ad = {};
- const __be32 *addr;
+ const __be32 *addr_be;
+ u32 addr;
int len;
dev_dbg(&adap->dev, "of_i2c: register %s\n", node->full_name);
@@ -1297,20 +1299,31 @@ static struct i2c_client *of_i2c_register_device(struct i2c_adapter *adap,
return ERR_PTR(-EINVAL);
}
- addr = of_get_property(node, "reg", &len);
- if (!addr || (len < sizeof(*addr))) {
+ addr_be = of_get_property(node, "reg", &len);
+ if (!addr_be || (len < sizeof(*addr_be))) {
dev_err(&adap->dev, "of_i2c: invalid reg on %s\n",
node->full_name);
return ERR_PTR(-EINVAL);
}
- info.addr = be32_to_cpup(addr);
- if (info.addr > (1 << 10) - 1) {
+ addr = be32_to_cpup(addr_be);
+ if (addr & I2C_TEN_BIT_ADDRESS) {
+ addr &= ~I2C_TEN_BIT_ADDRESS;
+ info.flags |= I2C_CLIENT_TEN;
+ }
+
+ if (addr & I2C_OWN_SLAVE_ADDRESS) {
+ addr &= ~I2C_OWN_SLAVE_ADDRESS;
+ info.flags |= I2C_CLIENT_SLAVE;
+ }
+
+ if (i2c_check_addr_validity(addr, info.flags)) {
dev_err(&adap->dev, "of_i2c: invalid addr=%x on %s\n",
info.addr, node->full_name);
return ERR_PTR(-EINVAL);
}
+ info.addr = addr;
info.of_node = of_node_get(node);
info.archdata = &dev_ad;
--
2.1.4
next prev parent reply other threads:[~2015-08-08 20:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-08 20:33 [PATCH 00/10] i2c: improve i2c client address spaces and their DT support Wolfram Sang
2015-08-08 20:33 ` [PATCH 01/10] dt-bindings: add header for generic I2C flags in bindings Wolfram Sang
2015-08-08 20:33 ` [PATCH 02/10] i2c: add a flag to mark clients as slaves Wolfram Sang
[not found] ` <1439066007-13951-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-08-08 20:33 ` [PATCH 03/10] i2c: apply address offset for slaves, too Wolfram Sang
2015-08-08 20:33 ` [PATCH 09/10] i2c: slave: print warning if slave flag not set Wolfram Sang
2015-08-08 20:33 ` [PATCH 04/10] i2c: rename address check functions Wolfram Sang
2015-08-08 20:33 ` [PATCH 05/10] i2c: make address check indpendent from client struct Wolfram Sang
2015-08-08 20:33 ` Wolfram Sang [this message]
2015-08-08 20:33 ` [PATCH 07/10] i2c: take address space into account when checking for used addresses Wolfram Sang
2015-08-08 20:33 ` [PATCH 08/10] i2c: support 10 bit and slave addresses in sysfs 'new_device' Wolfram Sang
2015-08-10 13:17 ` Geert Uytterhoeven
2015-08-10 14:00 ` Wolfram Sang
2015-08-08 20:33 ` [PATCH 10/10] i2c: dt: describe generic bindings Wolfram Sang
2015-08-09 9:51 ` Vaibhav Hiremath
2015-08-09 12:15 ` Wolfram Sang
2015-08-09 12:17 ` Vaibhav Hiremath
2015-08-14 18:22 ` [PATCH 00/10] i2c: improve i2c client address spaces and their DT support Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439066007-13951-7-git-send-email-wsa@the-dreams.de \
--to=wsa@the-dreams.de \
--cc=danindrey@mail.ru \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).