From: Wolfram Sang <wsa@the-dreams.de>
To: linux-i2c@vger.kernel.org
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Wolfram Sang <wsa@the-dreams.de>,
Andrey Danin <danindrey@mail.ru>,
Stephen Warren <swarren@wwwdotorg.org>,
Stephen Warren <swarren@nvidia.com>
Subject: [PATCH 07/10] i2c: take address space into account when checking for used addresses
Date: Sat, 8 Aug 2015 22:33:24 +0200 [thread overview]
Message-ID: <1439066007-13951-8-git-send-email-wsa@the-dreams.de> (raw)
In-Reply-To: <1439066007-13951-1-git-send-email-wsa@the-dreams.de>
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
It is not enough to compare the plain address value, we also need to
check the flags enabling a different address space. E.g. it is valid to
have address 0x50 as a 7-bit address and 0x050 as 10-bit address on the
same bus. Same for addresses when we are the slave.
Tested-by: Andrey Danin <danindrey@mail.ru>
Acked-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/i2c/i2c-core.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 7638eb1a5998f8..24c96dd0a5bee4 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -837,7 +837,7 @@ static int __i2c_check_addr_busy(struct device *dev, void *addrp)
struct i2c_client *client = i2c_verify_client(dev);
int addr = *(int *)addrp;
- if (client && client->addr == addr)
+ if (client && i2c_encode_flags_to_addr(client) == addr)
return -EBUSY;
return 0;
}
@@ -991,7 +991,7 @@ i2c_new_device(struct i2c_adapter *adap, struct i2c_board_info const *info)
}
/* Check for address business */
- status = i2c_check_addr_busy(adap, client->addr);
+ status = i2c_check_addr_busy(adap, i2c_encode_flags_to_addr(client));
if (status)
goto out_err;
@@ -2287,7 +2287,7 @@ static int i2c_detect_address(struct i2c_client *temp_client,
return err;
}
- /* Skip if already in use */
+ /* Skip if already in use (7 bit, no need to encode flags) */
if (i2c_check_addr_busy(adapter, addr))
return 0;
@@ -2403,7 +2403,7 @@ i2c_new_probed_device(struct i2c_adapter *adap,
continue;
}
- /* Check address availability */
+ /* Check address availability (7 bit, no need to encode flags) */
if (i2c_check_addr_busy(adap, addr_list[i])) {
dev_dbg(&adap->dev, "Address 0x%02x already in "
"use, not probing\n", addr_list[i]);
--
2.1.4
next prev parent reply other threads:[~2015-08-08 20:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-08 20:33 [PATCH 00/10] i2c: improve i2c client address spaces and their DT support Wolfram Sang
2015-08-08 20:33 ` [PATCH 01/10] dt-bindings: add header for generic I2C flags in bindings Wolfram Sang
2015-08-08 20:33 ` [PATCH 02/10] i2c: add a flag to mark clients as slaves Wolfram Sang
2015-08-08 20:33 ` [PATCH 04/10] i2c: rename address check functions Wolfram Sang
2015-08-08 20:33 ` [PATCH 05/10] i2c: make address check indpendent from client struct Wolfram Sang
2015-08-08 20:33 ` [PATCH 06/10] i2c: apply DT flags when probing Wolfram Sang
2015-08-08 20:33 ` Wolfram Sang [this message]
2015-08-08 20:33 ` [PATCH 08/10] i2c: support 10 bit and slave addresses in sysfs 'new_device' Wolfram Sang
2015-08-10 13:17 ` Geert Uytterhoeven
2015-08-10 14:00 ` Wolfram Sang
[not found] ` <1439066007-13951-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-08-08 20:33 ` [PATCH 03/10] i2c: apply address offset for slaves, too Wolfram Sang
2015-08-08 20:33 ` [PATCH 09/10] i2c: slave: print warning if slave flag not set Wolfram Sang
2015-08-08 20:33 ` [PATCH 10/10] i2c: dt: describe generic bindings Wolfram Sang
2015-08-09 9:51 ` Vaibhav Hiremath
2015-08-09 12:15 ` Wolfram Sang
2015-08-09 12:17 ` Vaibhav Hiremath
2015-08-14 18:22 ` [PATCH 00/10] i2c: improve i2c client address spaces and their DT support Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439066007-13951-8-git-send-email-wsa@the-dreams.de \
--to=wsa@the-dreams.de \
--cc=danindrey@mail.ru \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).