From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c <linux-i2c@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [RESEND PATCH 8/9] eeprom: at24: remove a reduntant if
Date: Tue, 20 Oct 2015 10:43:26 +0200 [thread overview]
Message-ID: <1445330607-12470-9-git-send-email-bgolaszewski@baylibre.com> (raw)
In-Reply-To: <1445330607-12470-1-git-send-email-bgolaszewski@baylibre.com>
It seems as if the second check for I2C_FUNC_I2C functionality had been
introduced accidentally during a merge. Tt's reduntant, so remove it.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
drivers/misc/eeprom/at24.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index b5181a3..52875f4 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -613,10 +613,7 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id)
} else {
return -EPFNOSUPPORT;
}
- }
- /* Use I2C operations unless we're stuck with SMBus extensions. */
- if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
if (i2c_check_functionality(client->adapter,
I2C_FUNC_SMBUS_WRITE_I2C_BLOCK)) {
use_smbus_write = I2C_SMBUS_I2C_BLOCK_DATA;
--
2.1.4
next prev parent reply other threads:[~2015-10-20 8:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 8:43 [RESEND PATCH 0/9] eeprom: at24: at24cs series serial number read Bartosz Golaszewski
2015-10-20 8:43 ` [RESEND PATCH 1/9] eeprom: at24: platform_data: use BIT() macro Bartosz Golaszewski
2015-10-20 8:43 ` [RESEND PATCH 2/9] eeprom: at24: new flag in platform_data Bartosz Golaszewski
2015-10-20 8:43 ` [RESEND PATCH 3/9] eeprom: at24: tie up an additional address for at24cs series Bartosz Golaszewski
2015-10-20 8:43 ` [RESEND PATCH 4/9] eeprom: at24: support reading of the serial number Bartosz Golaszewski
2015-10-20 8:43 ` [RESEND PATCH 5/9] eeprom: at24: export the serial number through sysfs Bartosz Golaszewski
2015-10-20 8:43 ` [RESEND PATCH 6/9] eeprom: at24: improve the device_id table readability Bartosz Golaszewski
2015-10-20 8:43 ` [RESEND PATCH 7/9] eeprom: at24: add the at24cs series to the list of supported devices Bartosz Golaszewski
2015-10-20 8:43 ` Bartosz Golaszewski [this message]
2015-10-20 8:43 ` [RESEND PATCH 9/9] eeprom: at24: readability tweaks Bartosz Golaszewski
2015-10-21 11:03 ` [RESEND PATCH 0/9] eeprom: at24: at24cs series serial number read Peter Korsgaard
2015-10-21 14:15 ` Bartosz Golaszewski
2015-10-21 14:23 ` Peter Korsgaard
2015-10-21 14:42 ` Bartosz Golaszewski
2015-10-21 15:08 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445330607-12470-9-git-send-email-bgolaszewski@baylibre.com \
--to=bgolaszewski@baylibre.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).