* [PATCH] i2c: designware: fix platform driver probe rename
@ 2015-10-21 9:16 Arnd Bergmann
2015-10-21 9:27 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2015-10-21 9:16 UTC (permalink / raw)
To: Wolfram Sang
Cc: Jarkko Nikula, Mika Westerberg, Andy Shevchenko, linux-i2c,
linux-kernel, linux-arm-kernel
A function rename was incomplete and missed the !CONFIG_PM
case:
i2c-designware-platdrv.c:340:13: error: 'dw_i2c_plat_prepare' undeclared here (not in a function)
i2c-designware-platdrv.c:341:14: error: 'dw_i2c_plat_complete' undeclared here (not in a function)
This renames the macros accordingly.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 6ad6fde3970c ("i2c: designware: Rename platform driver probe and PM functions")
---
Found on ARM randconfig builds
diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index f6b252a8ffd1..eb55760ccd9f 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -307,8 +307,8 @@ static void dw_i2c_plat_complete(struct device *dev)
pm_request_resume(dev);
}
#else
-#define dw_i2c_prepare NULL
-#define dw_i2c_complete NULL
+#define dw_i2c_plat_prepare NULL
+#define dw_i2c_plat_complete NULL
#endif
#ifdef CONFIG_PM
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c: designware: fix platform driver probe rename
2015-10-21 9:16 [PATCH] i2c: designware: fix platform driver probe rename Arnd Bergmann
@ 2015-10-21 9:27 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2015-10-21 9:27 UTC (permalink / raw)
To: Arnd Bergmann, Wolfram Sang
Cc: Jarkko Nikula, Mika Westerberg, linux-i2c, linux-kernel,
linux-arm-kernel
On Wed, 2015-10-21 at 11:16 +0200, Arnd Bergmann wrote:
> A function rename was incomplete and missed the !CONFIG_PM
> case:
>
> i2c-designware-platdrv.c:340:13: error: 'dw_i2c_plat_prepare'
> undeclared here (not in a function)
> i2c-designware-platdrv.c:341:14: error: 'dw_i2c_plat_complete'
> undeclared here (not in a function)
>
> This renames the macros accordingly.
Jarkko sent this already couple hours ago.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 6ad6fde3970c ("i2c: designware: Rename platform driver probe
> and PM functions")
> ---
> Found on ARM randconfig builds
>
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c
> b/drivers/i2c/busses/i2c-designware-platdrv.c
> index f6b252a8ffd1..eb55760ccd9f 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -307,8 +307,8 @@ static void dw_i2c_plat_complete(struct device
> *dev)
> pm_request_resume(dev);
> }
> #else
> -#define dw_i2c_prepare NULL
> -#define dw_i2c_complete NULL
> +#define dw_i2c_plat_prepare NULL
> +#define dw_i2c_plat_complete NULL
> #endif
>
> #ifdef CONFIG_PM
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-21 9:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-21 9:16 [PATCH] i2c: designware: fix platform driver probe rename Arnd Bergmann
2015-10-21 9:27 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).