From: LABBE Corentin <clabbe.montjoie@gmail.com>
To: gnurou@gmail.com, ldewangan@nvidia.com, swarren@wwwdotorg.org,
thierry.reding@gmail.com, wsa@the-dreams.de
Cc: LABBE Corentin <clabbe.montjoie@gmail.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: [PATCH] i2c: tegra: fix a possible NULL dereference
Date: Thu, 12 Nov 2015 08:26:03 +0100 [thread overview]
Message-ID: <1447313163-23848-1-git-send-email-clabbe.montjoie@gmail.com> (raw)
of_match_device could return NULL, and so cause a NULL pointer
dereference later at line 809:
i2c_dev->hw = match->data;
Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
drivers/i2c/busses/i2c-tegra.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index a0522fc..c803551 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -806,7 +806,10 @@ static int tegra_i2c_probe(struct platform_device *pdev)
if (pdev->dev.of_node) {
const struct of_device_id *match;
+
match = of_match_device(tegra_i2c_of_match, &pdev->dev);
+ if (!match)
+ return -ENODEV;
i2c_dev->hw = match->data;
i2c_dev->is_dvc = of_device_is_compatible(pdev->dev.of_node,
"nvidia,tegra20-i2c-dvc");
--
2.4.10
next reply other threads:[~2015-11-12 7:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 7:26 LABBE Corentin [this message]
2015-11-12 12:29 ` [PATCH] i2c: tegra: fix a possible NULL dereference Thierry Reding
2015-11-12 12:54 ` LABBE Corentin
2015-11-12 13:28 ` Thierry Reding
2015-11-12 13:45 ` Uwe Kleine-König
[not found] ` <20151112134519.GJ24008-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-11-12 13:55 ` Thierry Reding
2015-11-12 14:54 ` LABBE Corentin
2015-11-12 16:14 ` Thierry Reding
2016-01-23 11:07 ` Wolfram Sang
2016-01-23 10:56 ` Wolfram Sang
2015-11-12 13:40 ` Jon Hunter
2015-11-12 13:55 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447313163-23848-1-git-send-email-clabbe.montjoie@gmail.com \
--to=clabbe.montjoie@gmail.com \
--cc=gnurou@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).