From: Li Yang <leoli@freescale.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, "Li Yang" <leoli@freescale.com>,
"Gao Pan" <b54642@freescale.com>
Subject: [PATCH v2] i2c: imx: make bus recovery through pinctrl optional
Date: Fri, 20 Nov 2015 15:45:50 -0600 [thread overview]
Message-ID: <1448055950-21190-1-git-send-email-leoli@freescale.com> (raw)
Since commit 1c4b6c3bcf30 ("i2c: imx: implement bus recovery") the driver
starts to use gpio/pinctrl to do i2c bus recovery. But pinctrl is not
always available for platforms using this driver such as ls1021a and
ls1043a, and the device tree binding also mentioned this gpio based
recovery mechanism as optional. The patch make it really optional that
the probe function won't bailout when pinctrl is not available and it
won't try to register recovery functions if pinctrl is NULL when the
PINCTRL is not enabled at all.
Signed-off-by: Li Yang <leoli@freescale.com>
Cc: Gao Pan <b54642@freescale.com>
---
v2: bailout on -ENOMEM and -EPROBE_DEFER
drivers/i2c/busses/i2c-imx.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index 9bb0b05..41289f8 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -1087,8 +1087,11 @@ static int i2c_imx_probe(struct platform_device *pdev)
return ret;
}
+ /* optional bus recovery feature through pinctrl */
i2c_imx->pinctrl = devm_pinctrl_get(&pdev->dev);
- if (IS_ERR(i2c_imx->pinctrl)) {
+ /* bailout on -ENOMEM or -EPROBE_DEFER, continue for other errors */
+ if (PTR_ERR(i2c_imx->pinctrl) == -ENOMEM ||
+ PTR_ERR(i2c_imx->pinctrl) == -EPROBE_DEFER) {
ret = PTR_ERR(i2c_imx->pinctrl);
goto clk_disable;
}
@@ -1126,7 +1129,10 @@ static int i2c_imx_probe(struct platform_device *pdev)
goto clk_disable;
}
- i2c_imx_init_recovery_info(i2c_imx, pdev);
+ if (IS_ERR_OR_NULL(i2c_imx->pinctrl))
+ dev_info(&pdev->dev, "can't get pinctrl, bus recovery feature disabled\n");
+ else
+ i2c_imx_init_recovery_info(i2c_imx, pdev);
/* Set up platform driver data */
platform_set_drvdata(pdev, i2c_imx);
--
2.3.3
next reply other threads:[~2015-11-20 22:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 21:45 Li Yang [this message]
2015-11-30 12:55 ` [PATCH v2] i2c: imx: make bus recovery through pinctrl optional Linus Walleij
2016-01-03 18:30 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448055950-21190-1-git-send-email-leoli@freescale.com \
--to=leoli@freescale.com \
--cc=b54642@freescale.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).