[PATCH 1/2] Document: i2c: Add a dt binding for mediatek MT2701 soc

[PATCH 1/2] Document: i2c: Add a dt binding for mediatek MT2701 soc

[Liguo Zhang]

Add a dt binding for the MT2701 soc.

Signed-off-by: Liguo Zhang <liguo.zhang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
 Documentation/devicetree/bindings/i2c/i2c-mt6577.txt | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
index 0ce6fa3..ef22ecf 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
@@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices.
 
 Required properties:
   - compatible: value should be either of the following.
-      (a) "mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c.
-      (b) "mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c.
-      (c) "mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c.
-      (d) "mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c.
-      (e) "mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c.
+	"mediatek,mt2701-i2c", for i2c compatible with mt2701 i2c.
+	"mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c.
+	"mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c.
+	"mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c.
+	"mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c.
+	"mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c.
   - reg: physical base address of the controller and dma base, length of memory
     mapped region.
   - interrupts: interrupt number to the cpu.
-- 
1.8.1.1.dirty

[PATCH 2/2] dts: MT2701: add i2c dts info for MT2701

[Liguo Zhang]

Add i2c dtsi node for MT2701.

Signed-off-by: Liguo Zhang <liguo.zhang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
 arch/arm/boot/dts/mt2701.dtsi | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
index bd88ae9..bb34770 100644
--- a/arch/arm/boot/dts/mt2701.dtsi
+++ b/arch/arm/boot/dts/mt2701.dtsi
@@ -159,6 +159,48 @@
 		      <0 0x10216000 0 0x2000>;
 	};
 
+	i2c0: i2c@11007000 {
+		compatible = "mediatek,mt2701-i2c",
+			     "mediatek,mt6577-i2c";
+		reg = <0 0x11007000 0 0x70>,
+		      <0 0x11000200 0 0x80>;
+		interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_LOW>;
+		clock-div = <16>;
+		clocks = <&pericfg CLK_PERI_I2C0>, <&pericfg CLK_PERI_AP_DMA>;
+		clock-names = "main", "dma";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		status = "disabled";
+	};
+
+	i2c1: i2c@11008000 {
+		compatible = "mediatek,mt2701-i2c",
+			     "mediatek,mt6577-i2c";
+		reg = <0 0x11008000 0 0x70>,
+		      <0 0x11000280 0 0x80>;
+		interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_LOW>;
+		clock-div = <16>;
+		clocks = <&pericfg CLK_PERI_I2C1>, <&pericfg CLK_PERI_AP_DMA>;
+		clock-names = "main", "dma";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		status = "disabled";
+	};
+
+	i2c2: i2c@11009000 {
+		compatible = "mediatek,mt2701-i2c",
+			     "mediatek,mt6577-i2c";
+		reg = <0 0x11009000 0 0x70>,
+		      <0 0x11000300 0 0x80>;
+		interrupts = <GIC_SPI 46 IRQ_TYPE_LEVEL_LOW>;
+		clock-div = <16>;
+		clocks = <&pericfg CLK_PERI_I2C2>, <&pericfg CLK_PERI_AP_DMA>;
+		clock-names = "main", "dma";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		status = "disabled";
+	};
+
 	uart0: serial@11002000 {
 		compatible = "mediatek,mt2701-uart",
 			     "mediatek,mt6577-uart";
-- 
1.8.1.1.dirty

Re: [PATCH 1/2] Document: i2c: Add a dt binding for mediatek MT2701 soc

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

On Mon, Jan 04, 2016 at 02:15:37PM +0800, Liguo Zhang wrote:
> Add a dt binding for the MT2701 soc.
> 
> Signed-off-by: Liguo Zhang <liguo.zhang@mediatek.com>

This should probably go with the other patch via arm-soc, or?

In that case:

Acked-by: Wolfram Sang <wsa@the-dreams.de>


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 1/2] Document: i2c: Add a dt binding for mediatek MT2701 soc

[liguo zhang]

On Mon, 2016-01-04 at 10:55 +0100, Wolfram Sang wrote:
> On Mon, Jan 04, 2016 at 02:15:37PM +0800, Liguo Zhang wrote:
> > Add a dt binding for the MT2701 soc.
> > 
> > Signed-off-by: Liguo Zhang <liguo.zhang@mediatek.com>
> 
> This should probably go with the other patch via arm-soc, or?

The patch about i2c dts info for MT2701 depends on the MT2701 clock
patch. After the MT2701 clock patch is accepted, the i2c patch for
MT2701 may be accepted.

The MT2701 clock patch:
http://lists.infradead.org/pipermail/linux-mediatek/2016-January/003489.html

> 
> In that case:
> 
> Acked-by: Wolfram Sang <wsa@the-dreams.de>
> 

Re: [PATCH 1/2] Document: i2c: Add a dt binding for mediatek MT2701 soc

[liguo zhang]

On Mon, 2016-01-04 at 10:55 +0100, Wolfram Sang wrote:
> On Mon, Jan 04, 2016 at 02:15:37PM +0800, Liguo Zhang wrote:
> > Add a dt binding for the MT2701 soc.
> > 
> > Signed-off-by: Liguo Zhang <liguo.zhang@mediatek.com>
> 
> This should probably go with the other patch via arm-soc, or?

The patch about i2c dts info for MT2701 depends on the MT2701 clock
patch. After the MT2701 clock patch is accepted, the i2c patch for
MT2701 may be accepted.

The MT2701 clock patch:
http://lists.infradead.org/pipermail/linux-mediatek/2016-January/003489.html

> 
> In that case:
> 
> Acked-by: Wolfram Sang <wsa@the-dreams.de>
> 

Re: [PATCH 1/2] Document: i2c: Add a dt binding for mediatek MT2701 soc

[Wolfram Sang]

[-- Attachment #1.1: Type: text/plain, Size: 676 bytes --]

On Fri, Jan 08, 2016 at 09:12:53AM +0800, liguo zhang wrote:
> On Mon, 2016-01-04 at 10:55 +0100, Wolfram Sang wrote:
> > On Mon, Jan 04, 2016 at 02:15:37PM +0800, Liguo Zhang wrote:
> > > Add a dt binding for the MT2701 soc.
> > > 
> > > Signed-off-by: Liguo Zhang <liguo.zhang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > 
> > This should probably go with the other patch via arm-soc, or?
> 
> The patch about i2c dts info for MT2701 depends on the MT2701 clock
> patch. After the MT2701 clock patch is accepted, the i2c patch for
> MT2701 may be accepted.

OK. Still, dts changes go via arm-soc 99% of the cases if there is no
specific need to go via i2c.


[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 200 bytes --]

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

Re: [PATCH 1/2] Document: i2c: Add a dt binding for mediatek MT2701 soc

[Matthias Brugger]

On 08/01/16 08:45, Wolfram Sang wrote:
> On Fri, Jan 08, 2016 at 09:12:53AM +0800, liguo zhang wrote:
>> On Mon, 2016-01-04 at 10:55 +0100, Wolfram Sang wrote:
>>> On Mon, Jan 04, 2016 at 02:15:37PM +0800, Liguo Zhang wrote:
>>>> Add a dt binding for the MT2701 soc.
>>>>
>>>> Signed-off-by: Liguo Zhang <liguo.zhang@mediatek.com>
>>>
>>> This should probably go with the other patch via arm-soc, or?
>>
>> The patch about i2c dts info for MT2701 depends on the MT2701 clock
>> patch. After the MT2701 clock patch is accepted, the i2c patch for
>> MT2701 may be accepted.
>
> OK. Still, dts changes go via arm-soc 99% of the cases if there is no
> specific need to go via i2c.
>

No specific need here. I will take it through my branch as soon as the 
clock driver is accepted.

Liguo, please poke me on this, when this has happened and you have the 
feeling, I forgot about.