From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH] i2c: designware: retry transfer on transient failure Date: Tue, 05 Jan 2016 14:22:28 +0200 Message-ID: <1451996548.30729.398.camel@linux.intel.com> References: <1451320480.30729.351.camel@linux.intel.com> <20160104194949.GE1522@katana> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com ([134.134.136.65]:23679 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751716AbcAEMYP (ORCPT ); Tue, 5 Jan 2016 07:24:15 -0500 In-Reply-To: <20160104194949.GE1522@katana> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Wolfram Sang Cc: Baruch Siach , Jarkko Nikula , Mika Westerberg , linux-i2c@vger.kernel.org, Rolland Chau On Mon, 2016-01-04 at 20:49 +0100, Wolfram Sang wrote: > > After that, introduce a new property 'linux,i2c-retry-count' to be > > used > > as retries field in struct i2c_adapter. > > Hmm, to be honest, I always have difficulties with this "retries" > parameter; to me "try x milliseconds" makes more sense than "try 5 > times". It is there for ages, so we have to stick with it, but > frankly, > I wouldn't like to expose it too much :) Point taken. > I'm okay with the original patch putting some "sane" initial value. > It > can be modified at runtime via a i2c-dev ioctl if needed. Ah, good. So, I'm fine with it if no one has strong argument. -- Andy Shevchenko Intel Finland Oy