Re: [PATCH] i2c-piix4: Fix SB800 locking

[Jean Delvare <jdelvare@suse.de>]

Le Tuesday 26 January 2016 à 06:42 +0100, Wolfram Sang a écrit :
> On Fri, Jan 22, 2016 at 02:12:02PM +0100, Jean Delvare wrote:
> > We need a single mutex for all 4 shared SMBus ports on the SB800. A
> > per-port mutex doesn't protect us from concurrent access.
> > 
> > In theory the mutex should be per PCI device, however in practice we
> > know that there's only ever a single instance of the device in a given
> > system so we can use a global.
> > 
> > Also take the mutex during initialization, as first port may be already
> > in use when second port is initialized.
> > 
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Cc: Christian Fetzer <fetzer.ch@gmail.com>
> > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Cc: Wolfram Sang <wsa@the-dreams.de>
> 
> Fixed a sparse warning by making the mutex static, took the freedom to
> read Christian's mail as Tested-by and applied to for-current, thanks!

Oh, I thought I had fixed that before submitting but clearly I forgot.
Thanks for doing it :)

I'll send a patch restoring I2C bus names for older devices later today.
I have a few other fixups in mind but the rest isn't as urgent.

-- 
Jean Delvare
SUSE L3 Support