linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Wolfram Sang <wsa@the-dreams.de>,
	linux-i2c <linux-i2c@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH 08/13] eeprom: at24: call read and write routines via function pointers
Date: Thu, 24 Mar 2016 15:46:02 +0100	[thread overview]
Message-ID: <1458830767-23816-9-git-send-email-bgolaszewski@baylibre.com> (raw)
In-Reply-To: <1458830767-23816-1-git-send-email-bgolaszewski@baylibre.com>

In order to support non-standard read/write functions (as part of the
at24cs series support) introduce two function pointers in struct
at24_data to which different implementations can be assigned.

For now we continue to use the regular read/write routines by default.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 drivers/misc/eeprom/at24.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index a7d6c15..5b484bc 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -59,6 +59,9 @@ struct at24_data {
 	int use_smbus;
 	int use_smbus_write;
 
+	int (*read_func)(struct at24_data *, char *, loff_t, size_t);
+	int (*write_func)(struct at24_data *, const char *, loff_t, size_t);
+
 	u8 *writebuf;
 	struct mutex wrbuf_lock;
 	unsigned write_max;
@@ -458,7 +461,7 @@ static int at24_regmap_read(void *context, const void *reg, size_t reg_size,
 	off_t offset = *(u32 *)reg;
 	int err;
 
-	err = at24_read(at24, val, offset, val_size);
+	err = at24->read_func(at24, val, offset, val_size);
 	if (err)
 		return err;
 	return 0;
@@ -476,7 +479,7 @@ static int at24_regmap_write(void *context, const void *data, size_t count)
 	buf = (const char *)data + sizeof(offset);
 	len = count - sizeof(offset);
 
-	err = at24_write(at24, buf, offset, len);
+	err = at24->write_func(at24, buf, offset, len);
 	if (err)
 		return err;
 	return 0;
@@ -611,6 +614,9 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id)
 	at24->chip = chip;
 	at24->num_addresses = num_addresses;
 
+	at24->read_func = at24_read;
+	at24->write_func = at24_write;
+
 	writable = !(chip.flags & AT24_FLAG_READONLY);
 	if (writable) {
 		if (!use_smbus || use_smbus_write) {
-- 
2.7.4

  parent reply	other threads:[~2016-03-24 14:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-24 14:45 [PATCH 00/13] eeprom: support for at24cs and at24mac Bartosz Golaszewski
2016-03-24 14:45 ` [PATCH 01/13] eeprom: at24: remove a reduntant if Bartosz Golaszewski
2016-03-24 14:45 ` [PATCH 02/13] eeprom: at24: improve the device_id table readability Bartosz Golaszewski
2016-03-24 14:45 ` [PATCH 03/13] eeprom: at24: platform_data: use BIT() macro Bartosz Golaszewski
2016-03-24 14:45 ` [PATCH 04/13] eeprom: at24: make locking more fine-grained Bartosz Golaszewski
2016-03-24 14:45 ` [PATCH 05/13] eeprom: at24: replace msleep() with usleep_range() Bartosz Golaszewski
2016-03-24 14:46 ` [PATCH 06/13] eeprom: at24: add serial number flag Bartosz Golaszewski
2016-03-24 14:46 ` [PATCH 07/13] eeprom: at24: support reading of the serial number Bartosz Golaszewski
2016-03-24 14:46 ` Bartosz Golaszewski [this message]
2016-03-24 15:12   ` [PATCH 08/13] eeprom: at24: call read and write routines via function pointers kbuild test robot
2016-03-24 15:13   ` kbuild test robot
2016-03-24 14:46 ` [PATCH 09/13] eeprom: at24: use at24cs_serial_read() Bartosz Golaszewski
2016-03-24 14:46 ` [PATCH 10/13] eeprom: at24: add the at24cs series to the list of supported devices Bartosz Golaszewski
2016-03-24 14:46 ` [PATCH 11/13] eeprom: at24: add at24mac series flag Bartosz Golaszewski
2016-03-24 14:46 ` [PATCH 12/13] eeprom: at24: add support for at24mac series Bartosz Golaszewski
2016-03-24 14:46 ` [PATCH 13/13] eeprom: at24: add at24mac chips to the list of supported devices Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1458830767-23816-9-git-send-email-bgolaszewski@baylibre.com \
    --to=bgolaszewski@baylibre.com \
    --cc=andrew@lunn.ch \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).