From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c <linux-i2c@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH v2 01/13] eeprom: at24: remove a reduntant if
Date: Thu, 24 Mar 2016 17:19:31 +0100 [thread overview]
Message-ID: <1458836383-6668-2-git-send-email-bgolaszewski@baylibre.com> (raw)
In-Reply-To: <1458836383-6668-1-git-send-email-bgolaszewski@baylibre.com>
It seems as if the second check for I2C_FUNC_I2C functionality had
been introduced accidentally during a merge. Tt's reduntant, so
remove it.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
drivers/misc/eeprom/at24.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 089d694..001a9af 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -544,10 +544,7 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id)
} else {
return -EPFNOSUPPORT;
}
- }
- /* Use I2C operations unless we're stuck with SMBus extensions. */
- if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
if (i2c_check_functionality(client->adapter,
I2C_FUNC_SMBUS_WRITE_I2C_BLOCK)) {
use_smbus_write = I2C_SMBUS_I2C_BLOCK_DATA;
--
2.7.4
next prev parent reply other threads:[~2016-03-24 16:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 16:19 [PATCH v2 00/13] eeprom: support for at24cs and at24mac Bartosz Golaszewski
2016-03-24 16:19 ` Bartosz Golaszewski [this message]
2016-03-24 16:19 ` [PATCH v2 02/13] eeprom: at24: improve the device_id table readability Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 03/13] eeprom: at24: platform_data: use BIT() macro Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 04/13] eeprom: at24: make locking more fine-grained Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 05/13] eeprom: at24: replace msleep() with usleep_range() Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 06/13] eeprom: at24: add serial number flag Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 07/13] eeprom: at24: support reading of the serial number Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 08/13] eeprom: at24: call read and write routines via function pointers Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 09/13] eeprom: at24: use at24cs_serial_read() Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 10/13] eeprom: at24: add the at24cs series to the list of supported devices Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 11/13] eeprom: at24: add at24mac series flag Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 12/13] eeprom: at24: add support for at24mac series Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 13/13] eeprom: at24: add at24mac chips to the list of supported devices Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458836383-6668-2-git-send-email-bgolaszewski@baylibre.com \
--to=bgolaszewski@baylibre.com \
--cc=andrew@lunn.ch \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).