From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Wolfram Sang <wsa@the-dreams.de>,
linux-i2c <linux-i2c@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH v2 08/13] eeprom: at24: call read and write routines via function pointers
Date: Thu, 24 Mar 2016 17:19:38 +0100 [thread overview]
Message-ID: <1458836383-6668-9-git-send-email-bgolaszewski@baylibre.com> (raw)
In-Reply-To: <1458836383-6668-1-git-send-email-bgolaszewski@baylibre.com>
In order to support non-standard read/write functions (as part of the
at24cs series support) introduce two function pointers in struct
at24_data to which different implementations can be assigned.
For now we continue to use the regular read/write routines by default.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
drivers/misc/eeprom/at24.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index fda5c56..4c868a2 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -59,6 +59,10 @@ struct at24_data {
int use_smbus;
int use_smbus_write;
+ ssize_t (*read_func)(struct at24_data *, char *, loff_t, size_t);
+ ssize_t (*write_func)(struct at24_data *,
+ const char *, loff_t, size_t);
+
u8 *writebuf;
struct mutex wrbuf_lock;
unsigned write_max;
@@ -458,7 +462,7 @@ static int at24_regmap_read(void *context, const void *reg, size_t reg_size,
off_t offset = *(u32 *)reg;
int err;
- err = at24_read(at24, val, offset, val_size);
+ err = at24->read_func(at24, val, offset, val_size);
if (err)
return err;
return 0;
@@ -476,7 +480,7 @@ static int at24_regmap_write(void *context, const void *data, size_t count)
buf = (const char *)data + sizeof(offset);
len = count - sizeof(offset);
- err = at24_write(at24, buf, offset, len);
+ err = at24->write_func(at24, buf, offset, len);
if (err)
return err;
return 0;
@@ -611,6 +615,9 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id)
at24->chip = chip;
at24->num_addresses = num_addresses;
+ at24->read_func = at24_read;
+ at24->write_func = at24_write;
+
writable = !(chip.flags & AT24_FLAG_READONLY);
if (writable) {
if (!use_smbus || use_smbus_write) {
--
2.7.4
next prev parent reply other threads:[~2016-03-24 16:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 16:19 [PATCH v2 00/13] eeprom: support for at24cs and at24mac Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 01/13] eeprom: at24: remove a reduntant if Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 02/13] eeprom: at24: improve the device_id table readability Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 03/13] eeprom: at24: platform_data: use BIT() macro Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 04/13] eeprom: at24: make locking more fine-grained Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 05/13] eeprom: at24: replace msleep() with usleep_range() Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 06/13] eeprom: at24: add serial number flag Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 07/13] eeprom: at24: support reading of the serial number Bartosz Golaszewski
2016-03-24 16:19 ` Bartosz Golaszewski [this message]
2016-03-24 16:19 ` [PATCH v2 09/13] eeprom: at24: use at24cs_serial_read() Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 10/13] eeprom: at24: add the at24cs series to the list of supported devices Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 11/13] eeprom: at24: add at24mac series flag Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 12/13] eeprom: at24: add support for at24mac series Bartosz Golaszewski
2016-03-24 16:19 ` [PATCH v2 13/13] eeprom: at24: add at24mac chips to the list of supported devices Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458836383-6668-9-git-send-email-bgolaszewski@baylibre.com \
--to=bgolaszewski@baylibre.com \
--cc=andrew@lunn.ch \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).