From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org,
CT kernel <linux-kernel@lists.codethink.co.uk>
Subject: [PATCH] i2c: mux: demux-pinctrl: Fix reading the "master" attribute
Date: Wed, 30 Mar 2016 17:27:16 +0100 [thread overview]
Message-ID: <1459355236.27975.5.camel@codethink.co.uk> (raw)
sysfs attributes should use the same format for reads and writes,
rather than pretty-printing on read.
Fixes: 50a5ba876908 ("i2c: mux: demux-pinctrl: add driver")
Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
---
drivers/i2c/muxes/i2c-demux-pinctrl.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-demux-pinctrl.c b/drivers/i2c/muxes/i2c-demux-pinctrl.c
index 7748a0a5ddb9..9e8f3d702314 100644
--- a/drivers/i2c/muxes/i2c-demux-pinctrl.c
+++ b/drivers/i2c/muxes/i2c-demux-pinctrl.c
@@ -144,14 +144,8 @@ static ssize_t cur_master_show(struct device *dev, struct device_attribute *attr
char *buf)
{
struct i2c_demux_pinctrl_priv *priv = dev_get_drvdata(dev);
- int count = 0, i;
- for (i = 0; i < priv->num_chan && count < PAGE_SIZE; i++)
- count += scnprintf(buf + count, PAGE_SIZE - count, "%c %d - %s\n",
- i == priv->cur_chan ? '*' : ' ', i,
- priv->chan[i].parent_np->full_name);
-
- return count;
+ return sprintf(buf, "%u\n", priv->cur_chan);
}
static ssize_t cur_master_store(struct device *dev, struct device_attribute *attr,
--
Ben Hutchings
Software Developer, Codethink Ltd.
next reply other threads:[~2016-03-30 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 16:27 Ben Hutchings [this message]
2016-03-30 16:42 ` [Linux-kernel] [PATCH] i2c: mux: demux-pinctrl: Fix reading the "master" attribute Ben Dooks
2016-03-30 16:45 ` Ben Hutchings
2016-03-30 20:56 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459355236.27975.5.camel@codethink.co.uk \
--to=ben.hutchings@codethink.co.uk \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).