* [PATCH] i2c: s3c2410: fix indentation for better readability
@ 2016-04-24 21:28 Wolfram Sang
2016-04-25 8:55 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2016-04-24 21:28 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang, Krzysztof Kozlowski, linux-samsung-soc
smatch rightfully says:
drivers/i2c/busses/i2c-s3c2410.c:1217 s3c24xx_i2c_probe() warn: inconsistent indenting
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/i2c/busses/i2c-s3c2410.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index 1bc756313cb8e4..315c88ea1fa153 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -1214,8 +1214,8 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
return ret;
}
- ret = devm_request_irq(&pdev->dev, i2c->irq, s3c24xx_i2c_irq, 0,
- dev_name(&pdev->dev), i2c);
+ ret = devm_request_irq(&pdev->dev, i2c->irq, s3c24xx_i2c_irq, 0,
+ dev_name(&pdev->dev), i2c);
if (ret != 0) {
dev_err(&pdev->dev, "cannot claim IRQ %d\n", i2c->irq);
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] i2c: s3c2410: fix indentation for better readability
2016-04-24 21:28 [PATCH] i2c: s3c2410: fix indentation for better readability Wolfram Sang
@ 2016-04-25 8:55 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2016-04-25 8:55 UTC (permalink / raw)
To: Wolfram Sang, linux-i2c; +Cc: linux-samsung-soc
On 04/24/2016 11:28 PM, Wolfram Sang wrote:
> smatch rightfully says:
>
> drivers/i2c/busses/i2c-s3c2410.c:1217 s3c24xx_i2c_probe() warn: inconsistent indenting
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
> drivers/i2c/busses/i2c-s3c2410.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Hi,
You could just apply this one:
i2c: s3c2410: Cleanup indentation and comment style
https://lkml.org/lkml/2016/4/20/163
I fixed this in that patch. Its trivial so it does not have to be a
separate patch.
Best regards,
Krzysztof
>
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index 1bc756313cb8e4..315c88ea1fa153 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -1214,8 +1214,8 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
> return ret;
> }
>
> - ret = devm_request_irq(&pdev->dev, i2c->irq, s3c24xx_i2c_irq, 0,
> - dev_name(&pdev->dev), i2c);
> + ret = devm_request_irq(&pdev->dev, i2c->irq, s3c24xx_i2c_irq, 0,
> + dev_name(&pdev->dev), i2c);
>
> if (ret != 0) {
> dev_err(&pdev->dev, "cannot claim IRQ %d\n", i2c->irq);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-25 8:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-24 21:28 [PATCH] i2c: s3c2410: fix indentation for better readability Wolfram Sang
2016-04-25 8:55 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).