From: Jan Glauber <jglauber@cavium.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
David Daney <ddaney@caviumnetworks.com>,
David Daney <david.daney@cavium.com>,
Jan Glauber <jglauber@cavium.com>
Subject: [PATCH v7 07/15] i2c: octeon: Add support for cn78xx chips
Date: Mon, 25 Apr 2016 16:33:36 +0200 [thread overview]
Message-ID: <1461594824-7215-8-git-send-email-jglauber@cavium.com> (raw)
In-Reply-To: <1461594824-7215-1-git-send-email-jglauber@cavium.com>
From: David Daney <david.daney@cavium.com>
cn78xx has a different interrupt architecture, so we have to manage
the interrupts differently.
Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Signed-off-by: Jan Glauber <jglauber@cavium.com>
---
drivers/i2c/busses/i2c-octeon.c | 131 ++++++++++++++++++++++++++++++++++++----
1 file changed, 120 insertions(+), 11 deletions(-)
diff --git a/drivers/i2c/busses/i2c-octeon.c b/drivers/i2c/busses/i2c-octeon.c
index 9520f78..76fa479 100644
--- a/drivers/i2c/busses/i2c-octeon.c
+++ b/drivers/i2c/busses/i2c-octeon.c
@@ -11,6 +11,7 @@
* warranty of any kind, whether express or implied.
*/
+#include <linux/atomic.h>
#include <linux/platform_device.h>
#include <linux/interrupt.h>
#include <linux/kernel.h>
@@ -112,11 +113,18 @@ struct octeon_i2c {
wait_queue_head_t queue;
struct i2c_adapter adap;
int irq;
+ int hlc_irq; /* For cn7890 only */
u32 twsi_freq;
int sys_freq;
void __iomem *twsi_base;
struct device *dev;
bool hlc_enabled;
+ void (*int_enable)(struct octeon_i2c *);
+ void (*int_disable)(struct octeon_i2c *);
+ void (*hlc_int_enable)(struct octeon_i2c *);
+ void (*hlc_int_disable)(struct octeon_i2c *);
+ atomic_t int_enable_cnt;
+ atomic_t hlc_int_enable_cnt;
};
static void octeon_i2c_writeq_flush(u64 val, void __iomem *addr)
@@ -217,6 +225,58 @@ static void octeon_i2c_int_disable(struct octeon_i2c *i2c)
octeon_i2c_write_int(i2c, 0);
}
+/**
+ * octeon_i2c_int_enable78 - enable the CORE interrupt
+ * @i2c: The struct octeon_i2c
+ *
+ * The interrupt will be asserted when there is non-STAT_IDLE state in the
+ * SW_TWSI_EOP_TWSI_STAT register.
+ */
+static void octeon_i2c_int_enable78(struct octeon_i2c *i2c)
+{
+ atomic_inc_return(&i2c->int_enable_cnt);
+ enable_irq(i2c->irq);
+}
+
+static void __octeon_i2c_irq_disable(atomic_t *cnt, int irq)
+{
+ int count;
+
+ /*
+ * The interrupt can be disabled in two places, but we only
+ * want to make the disable_irq_nosync() call once, so keep
+ * track with the atomic variable.
+ */
+ count = atomic_dec_if_positive(cnt);
+ if (count >= 0)
+ disable_irq_nosync(irq);
+}
+
+/* disable the CORE interrupt */
+static void octeon_i2c_int_disable78(struct octeon_i2c *i2c)
+{
+ __octeon_i2c_irq_disable(&i2c->int_enable_cnt, i2c->irq);
+}
+
+/**
+ * octeon_i2c_hlc_int_enable78 - enable the ST interrupt
+ * @i2c: The struct octeon_i2c
+ *
+ * The interrupt will be asserted when there is non-STAT_IDLE state in
+ * the SW_TWSI_EOP_TWSI_STAT register.
+ */
+static void octeon_i2c_hlc_int_enable78(struct octeon_i2c *i2c)
+{
+ atomic_inc_return(&i2c->hlc_int_enable_cnt);
+ enable_irq(i2c->hlc_irq);
+}
+
+/* disable the ST interrupt */
+static void octeon_i2c_hlc_int_disable78(struct octeon_i2c *i2c)
+{
+ __octeon_i2c_irq_disable(&i2c->hlc_int_enable_cnt, i2c->hlc_irq);
+}
+
/*
* Cleanup low-level state & enable high-level controller.
*/
@@ -263,7 +323,18 @@ static irqreturn_t octeon_i2c_isr(int irq, void *dev_id)
{
struct octeon_i2c *i2c = dev_id;
- octeon_i2c_int_disable(i2c);
+ i2c->int_disable(i2c);
+ wake_up(&i2c->queue);
+
+ return IRQ_HANDLED;
+}
+
+/* HLC interrupt service routine */
+static irqreturn_t octeon_i2c_hlc_isr78(int irq, void *dev_id)
+{
+ struct octeon_i2c *i2c = dev_id;
+
+ i2c->hlc_int_disable(i2c);
wake_up(&i2c->queue);
return IRQ_HANDLED;
@@ -284,10 +355,10 @@ static int octeon_i2c_wait(struct octeon_i2c *i2c)
{
long time_left;
- octeon_i2c_int_enable(i2c);
+ i2c->int_enable(i2c);
time_left = wait_event_timeout(i2c->queue, octeon_i2c_test_iflg(i2c),
i2c->adap.timeout);
- octeon_i2c_int_disable(i2c);
+ i2c->int_disable(i2c);
if (!time_left) {
dev_dbg(i2c->dev, "%s: timeout\n", __func__);
return -ETIMEDOUT;
@@ -385,11 +456,11 @@ static int octeon_i2c_hlc_wait(struct octeon_i2c *i2c)
{
int time_left;
- octeon_i2c_hlc_int_enable(i2c);
+ i2c->hlc_int_enable(i2c);
time_left = wait_event_timeout(i2c->queue,
octeon_i2c_hlc_test_ready(i2c),
i2c->adap.timeout);
- octeon_i2c_int_disable(i2c);
+ i2c->hlc_int_disable(i2c);
if (!time_left) {
octeon_i2c_hlc_int_clear(i2c);
return -ETIMEDOUT;
@@ -942,14 +1013,26 @@ static struct i2c_adapter octeon_i2c_ops = {
static int octeon_i2c_probe(struct platform_device *pdev)
{
struct device_node *node = pdev->dev.of_node;
+ int irq, result = 0, hlc_irq = 0;
struct resource *res_mem;
struct octeon_i2c *i2c;
- int irq, result = 0;
-
- /* All adaptors have an irq. */
- irq = platform_get_irq(pdev, 0);
- if (irq < 0)
- return irq;
+ bool cn78xx_style;
+
+ cn78xx_style = of_device_is_compatible(node, "cavium,octeon-7890-twsi");
+ if (cn78xx_style) {
+ hlc_irq = platform_get_irq(pdev, 0);
+ if (hlc_irq < 0)
+ return hlc_irq;
+
+ irq = platform_get_irq(pdev, 2);
+ if (irq < 0)
+ return irq;
+ } else {
+ /* All adaptors have an irq. */
+ irq = platform_get_irq(pdev, 0);
+ if (irq < 0)
+ return irq;
+ }
i2c = devm_kzalloc(&pdev->dev, sizeof(*i2c), GFP_KERNEL);
if (!i2c) {
@@ -984,6 +1067,31 @@ static int octeon_i2c_probe(struct platform_device *pdev)
i2c->irq = irq;
+ if (cn78xx_style) {
+ i2c->hlc_irq = hlc_irq;
+
+ i2c->int_enable = octeon_i2c_int_enable78;
+ i2c->int_disable = octeon_i2c_int_disable78;
+ i2c->hlc_int_enable = octeon_i2c_hlc_int_enable78;
+ i2c->hlc_int_disable = octeon_i2c_hlc_int_disable78;
+
+ irq_set_status_flags(i2c->irq, IRQ_NOAUTOEN);
+ irq_set_status_flags(i2c->hlc_irq, IRQ_NOAUTOEN);
+
+ result = devm_request_irq(&pdev->dev, i2c->hlc_irq,
+ octeon_i2c_hlc_isr78, 0,
+ DRV_NAME, i2c);
+ if (result < 0) {
+ dev_err(i2c->dev, "failed to attach interrupt\n");
+ goto out;
+ }
+ } else {
+ i2c->int_enable = octeon_i2c_int_enable;
+ i2c->int_disable = octeon_i2c_int_disable;
+ i2c->hlc_int_enable = octeon_i2c_hlc_int_enable;
+ i2c->hlc_int_disable = octeon_i2c_int_disable;
+ }
+
result = devm_request_irq(&pdev->dev, i2c->irq,
octeon_i2c_isr, 0, DRV_NAME, i2c);
if (result < 0) {
@@ -1030,6 +1138,7 @@ static int octeon_i2c_remove(struct platform_device *pdev)
static const struct of_device_id octeon_i2c_match[] = {
{ .compatible = "cavium,octeon-3860-twsi", },
+ { .compatible = "cavium,octeon-7890-twsi", },
{},
};
MODULE_DEVICE_TABLE(of, octeon_i2c_match);
--
1.9.1
next prev parent reply other threads:[~2016-04-25 14:33 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 14:33 [PATCH v7 00/15] i2c-octeon and i2c-thunderx drivers Jan Glauber
2016-04-25 14:33 ` [PATCH v7 01/15] i2c: octeon: Improve error status checking Jan Glauber
2016-04-25 21:20 ` Wolfram Sang
2016-04-25 14:33 ` [PATCH v7 02/15] i2c: octeon: Use i2c recovery framework Jan Glauber
2016-04-25 21:29 ` Wolfram Sang
2016-04-25 14:33 ` [PATCH v7 03/15] i2c: octeon: Remove I2C_FUNC_SMBUS_QUICK support Jan Glauber
2016-04-25 22:16 ` Wolfram Sang
2016-04-25 22:28 ` David Daney
2016-04-26 5:58 ` Jan Glauber
2016-04-26 6:42 ` Jan Glauber
2016-04-26 7:36 ` Wolfram Sang
2016-04-26 12:34 ` Jan Glauber
2016-04-26 12:53 ` Wolfram Sang
2016-04-26 14:26 ` [PATCH] i2c: octeon: Remove zero-length message support Jan Glauber
2016-04-26 21:04 ` Wolfram Sang
2016-04-25 14:33 ` [PATCH v7 04/15] i2c: octeon: Add flush writeq helper function Jan Glauber
2016-04-25 21:33 ` Wolfram Sang
2016-04-25 14:33 ` [PATCH v7 05/15] i2c: octeon: Enable High-Level Controller Jan Glauber
2016-04-25 21:44 ` Wolfram Sang
2016-04-26 5:51 ` Jan Glauber
2016-04-25 14:33 ` [PATCH v7 06/15] dt-bindings: i2c: Add Octeon cn78xx TWSI Jan Glauber
2016-04-25 21:47 ` Wolfram Sang
2016-04-25 14:33 ` Jan Glauber [this message]
2016-04-25 21:47 ` [PATCH v7 07/15] i2c: octeon: Add support for cn78xx chips Wolfram Sang
2016-04-25 14:33 ` [PATCH v7 08/15] i2c: octeon: Improve performance if interrupt is early Jan Glauber
2016-04-26 21:10 ` Wolfram Sang
2016-04-26 21:19 ` Wolfram Sang
2016-04-25 14:33 ` [PATCH v7 09/15] i2c: octeon: Add workaround for broken irqs on CN3860 Jan Glauber
2016-04-26 21:17 ` Wolfram Sang
2016-04-27 9:37 ` Jan Glauber
2016-04-27 9:44 ` [PATCH] " Jan Glauber
2016-04-27 16:56 ` Wolfram Sang
2016-04-25 14:33 ` [PATCH v7 10/15] i2c: octeon: Move read function before write Jan Glauber
2016-04-25 14:33 ` [PATCH v7 11/15] i2c: octeon: Rename driver to prepare for split Jan Glauber
2016-04-25 14:33 ` [PATCH v7 12/15] i2c: octeon: Split the driver into two parts Jan Glauber
2016-04-25 14:33 ` [PATCH v7 13/15] i2c: thunderx: Add i2c driver for ThunderX SOC Jan Glauber
2016-04-25 14:33 ` [PATCH v7 14/15] i2c: octeon,thunderx: Move register offsets to struct Jan Glauber
2016-04-25 14:33 ` [PATCH v7 15/15] i2c: thunderx: Add smbus alert support Jan Glauber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461594824-7215-8-git-send-email-jglauber@cavium.com \
--to=jglauber@cavium.com \
--cc=david.daney@cavium.com \
--cc=ddaney@caviumnetworks.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).