From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: i2c-i801 partially broken on Lynx Point PCH? Date: Wed, 11 May 2016 19:34:31 +0200 Message-ID: <1462988071.6344.0.camel@chaos.suse> References: <20160511093452.5bc2614c@endymion> <20160511104322.60521365@endymion> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de ([195.135.220.15]:50622 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752417AbcEKRee (ORCPT ); Wed, 11 May 2016 13:34:34 -0400 In-Reply-To: Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: "Heasley, Seth" Cc: Linux I2C , Mika Westerberg , Jarkko Nikula On mer., 2016-05-11 at 16:15 +0000, Heasley, Seth wrote: > Hi Jean, > > > On Wed, 11 May 2016 09:34:52 +0200, Jean Delvare wrote: > > > In commit 062737fb6d90 you added support for the Intel Lynx Point PCH > > > to the i2c-i801 driver. I happen to have a machine with this chipset > > > since a few weeks, and found that the i2c-i801 driver doesn't work > > > properly on it. Specifically, the eeprom driver return 0xff for all > > > EEPROM bytes. The at24 driver fails too, with a timeout. > > > > > > After some testing using i2cdetect, i2cdump and i2cget, I found that > > > some I2C transactions work (SMBUS_QUICK, SMBUS_READ_BYTE, > > > SMBUS_READ_BYTE_DATA, SMBUS_READ_WORD_DATA, > > SMBUS_READ_BLOCK_DATA), > > > however others do not (SMBUS_WRITE_BYTE, SMBUS_READ_I2C_BLOCK.) I > > > can't easily test other transaction types as all I have on the SMBus > > > are SPD EEPROMs on my memory modules. > > > > > > Did you test the i2c-i801 driver on an actual Lynx Point PCH chipset? > > > Or did you only add the PCI ID of the device, assuming it would work? > > I tested on an Intel system with Lynx Point and saw everything working, consistent with what you're seeing on the SUSE system. Do you happen to know which revision it was? Thanks, -- Jean Delvare SUSE L3 Support