* [PATCH] i2c: I2C_RCAR should depend on HAS_DMA
@ 2016-05-22 7:38 Geert Uytterhoeven
2016-05-22 9:45 ` Niklas Söderlund
2016-05-26 18:44 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2016-05-22 7:38 UTC (permalink / raw)
To: Wolfram Sang, Niklas Söderlund
Cc: linux-i2c, linux-renesas-soc, Geert Uytterhoeven
If NO_DMA=y:
drivers/built-in.o: In function `rcar_i2c_dma_unmap':
i2c-rcar.c:(.text+0x6f06c6): undefined reference to `bad_dma_ops'
drivers/built-in.o: In function `rcar_i2c_dma':
i2c-rcar.c:(.text+0x6f07e2): undefined reference to `bad_dma_ops'
i2c-rcar.c:(.text+0x6f0838): undefined reference to `bad_dma_ops'
Add a dependency on HAS_DMA to fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/i2c/busses/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 2dd40ddf04de3117..8ffb0d7015b0f4fe 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -985,6 +985,7 @@ config I2C_XLP9XX
config I2C_RCAR
tristate "Renesas R-Car I2C Controller"
+ depends on HAS_DMA
depends on ARCH_RENESAS || COMPILE_TEST
select I2C_SLAVE
help
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] i2c: I2C_RCAR should depend on HAS_DMA
2016-05-22 7:38 [PATCH] i2c: I2C_RCAR should depend on HAS_DMA Geert Uytterhoeven
@ 2016-05-22 9:45 ` Niklas Söderlund
2016-05-26 18:44 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Niklas Söderlund @ 2016-05-22 9:45 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Wolfram Sang, linux-i2c, linux-renesas-soc
Hi Geert,
On 2016-05-22 09:38:35 +0200, Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> drivers/built-in.o: In function `rcar_i2c_dma_unmap':
> i2c-rcar.c:(.text+0x6f06c6): undefined reference to `bad_dma_ops'
> drivers/built-in.o: In function `rcar_i2c_dma':
> i2c-rcar.c:(.text+0x6f07e2): undefined reference to `bad_dma_ops'
> i2c-rcar.c:(.text+0x6f0838): undefined reference to `bad_dma_ops'
>
> Add a dependency on HAS_DMA to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/i2c/busses/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 2dd40ddf04de3117..8ffb0d7015b0f4fe 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -985,6 +985,7 @@ config I2C_XLP9XX
>
> config I2C_RCAR
> tristate "Renesas R-Car I2C Controller"
> + depends on HAS_DMA
> depends on ARCH_RENESAS || COMPILE_TEST
> select I2C_SLAVE
> help
> --
> 1.9.1
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: I2C_RCAR should depend on HAS_DMA
2016-05-22 7:38 [PATCH] i2c: I2C_RCAR should depend on HAS_DMA Geert Uytterhoeven
2016-05-22 9:45 ` Niklas Söderlund
@ 2016-05-26 18:44 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2016-05-26 18:44 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Niklas Söderlund, linux-i2c, linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 570 bytes --]
On Sun, May 22, 2016 at 09:38:35AM +0200, Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> drivers/built-in.o: In function `rcar_i2c_dma_unmap':
> i2c-rcar.c:(.text+0x6f06c6): undefined reference to `bad_dma_ops'
> drivers/built-in.o: In function `rcar_i2c_dma':
> i2c-rcar.c:(.text+0x6f07e2): undefined reference to `bad_dma_ops'
> i2c-rcar.c:(.text+0x6f0838): undefined reference to `bad_dma_ops'
>
> Add a dependency on HAS_DMA to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-26 18:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-22 7:38 [PATCH] i2c: I2C_RCAR should depend on HAS_DMA Geert Uytterhoeven
2016-05-22 9:45 ` Niklas Söderlund
2016-05-26 18:44 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).