From: Eric Anholt <eric@anholt.net>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>,
linux-i2c@vger.kernel.org, Eric Anholt <eric@anholt.net>
Subject: [PATCH] i2c: bcm2835: Set up the clock stretching timeout at boot.
Date: Wed, 1 Jun 2016 15:07:25 -0700 [thread overview]
Message-ID: <1464818845-5348-1-git-send-email-eric@anholt.net> (raw)
The register at poweron contains 0x40, which at our typical 100khz bus
rate means .64ms instead of the desired 25ms.
Fixes many clock stretching timeouts when talking to the DSI panel's
bridge chip, and will hopefully fix talking to the FXL6408 GPIO
expander on the Pi3 as well.
Signed-off-by: Eric Anholt <eric@anholt.net>
---
drivers/i2c/busses/i2c-bcm2835.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
index 818b051d25e6..1348f224013d 100644
--- a/drivers/i2c/busses/i2c-bcm2835.c
+++ b/drivers/i2c/busses/i2c-bcm2835.c
@@ -28,6 +28,11 @@
#define BCM2835_I2C_FIFO 0x10
#define BCM2835_I2C_DIV 0x14
#define BCM2835_I2C_DEL 0x18
+/*
+ * 16-bit field for the number of SCL cycles to wait after rising SCL
+ * before deciding the slave is not responding. 0 disables the
+ * timeout detection.
+ */
#define BCM2835_I2C_CLKT 0x1c
#define BCM2835_I2C_C_READ BIT(0)
@@ -238,6 +243,7 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
u32 bus_clk_rate, divider;
int ret;
struct i2c_adapter *adap;
+ u32 clkt;
i2c_dev = devm_kzalloc(&pdev->dev, sizeof(*i2c_dev), GFP_KERNEL);
if (!i2c_dev)
@@ -280,6 +286,15 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
}
bcm2835_i2c_writel(i2c_dev, BCM2835_I2C_DIV, divider);
+ /*
+ * SMBUS says "Devices participating in a transfer will
+ * timeout when any clock low exceeds the value of
+ * T_TIMEOUT,MIN of 25 ms."
+ */
+ clkt = DIV_ROUND_UP(25 * bus_clk_rate, 1000);
+ clkt = min(clkt, 0xffffu);
+ bcm2835_i2c_writel(i2c_dev, BCM2835_I2C_CLKT, clkt);
+
irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
if (!irq) {
dev_err(&pdev->dev, "No IRQ resource\n");
--
2.8.0.rc3
next reply other threads:[~2016-06-01 22:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 22:07 Eric Anholt [this message]
2016-06-02 16:35 ` [PATCH] i2c: bcm2835: Set up the clock stretching timeout at boot Stefan Wahren
[not found] ` <25336b03-76d1-2466-fbc0-9f363d3e7638@i2se.com>
2016-06-02 18:02 ` Eric Anholt
2016-07-04 0:31 ` Wolfram Sang
2016-07-04 1:02 ` Eric Anholt
2016-07-22 7:27 ` Wolfram Sang
2016-10-03 19:50 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464818845-5348-1-git-send-email-eric@anholt.net \
--to=eric@anholt.net \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=swarren@wwwdotorg.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).